pipe01 should only check the data actually received from the pipe
PATCH 1/1 pipe01 should only check the data actually received from the pipe
The pipe write does not include the string terminator and the way the test is written it's valid for the writer to send less than the requested amount and for the reader to read less than the number of written bytes, so just compare the actual bytes received.
--- testcases/kernel/syscalls/pipe/pipe01.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/testcases/kernel/syscalls/pipe/pipe01.c
index 08cf612..04d1b11 100644
testcases/kernel/syscalls/pipe/pipe01.c +2 -2
@@ -119,7 +119,7 @@ int main(int ac, char **av) }/* are the strings written and read equal */ -if ((greater =strcmp (rebuf, wrbuf)) !=0 ) { +if ((greater =strncmp (rebuf, wrbuf, red)) !=0 ) {tst_resm (TFAIL ,"Condition #3 test failed" );continue ; }
@@ -155,4 +155,4 @@ void cleanup()* print errno log if that option was specified. */ TEST_CLEANUP ; -} +}
Signature · 13 lines
1.7.1 ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
PATCH 1/1 pipe01 should only check the data actually received from the pipe
The pipe write does not include the string terminator. The way the test is written it's valid for the writer to send less than the requested data and for the reader to read less than the number of written bytes, so just compare the actual bytes received.
--- testcases/kernel/syscalls/pipe/pipe01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/syscalls/pipe/pipe01.c +1 -1
@@ -119,7 +119,7 @@ int main(int ac, char **av) }/* are the strings written and read equal */ -if ((greater =strcmp (rebuf, wrbuf)) !=0 ) { +if ((greater =strncmp (rebuf, wrbuf, red)) !=0 ) {tst_resm (TFAIL ,"Condition #3 test failed" );continue ; }
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 6 lines · Chris Dearman
The pipe write does not include the string terminator. The way the test is written it's valid for the writer to send less than the requested data and for the reader to read less than the number of written bytes, so just compare the actual bytes received.
Signed-off-by Chris Dearman <[email protected]>
Pushed with Cyril's Ack, thank you.
Wanlong Gao
Quoted 14 lines
--- testcases/kernel/syscalls/pipe/pipe01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
Quoted 5 lines
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list