Skip to contentSkip to conversation

qla3xxx: Ensure req_q_phy_addr writes to the register

PATCH In review Joe Jin 2 participants 4 messages Oct 17, 2012 – Oct 18, 2012

Subsystems (3)
Networking Network drivers QLogic QLA3XXX network driver
lore
Share & tools
lore

Joe Jin

author
#0 lore raw

PATCH 1/1 qla3xxx: Ensure req_q_phy_addr writes to the register

Make sure req_q_phy_addr write to the register.

Signed-off-by Joe Jin <[email protected]>
Cc Ron Mercer <[email protected]>
Cc Jitendra Kalsaria <[email protected]>
---
 drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/qlogic/qla3xxx.c +6 -0
index df09b1c..78b4cba 100644
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
 	qdev->req_q_size =
 	    (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
 
+	/*
+	 * The barrier is required to ensure that req_q_phy_addr writes to
+	 * the memory.
+	 */
+	wmb();
+
 	qdev->req_q_virt_addr =
 	    pci_alloc_consistent(qdev->pdev,
 				 (size_t) qdev->req_q_size,
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 25 lines

-----Original Message-----
From: Joe Jin [mailto:[email protected]]
Sent: Tuesday, October 16, 2012 11:32 PM
To: Ron Mercer; Jitendra Kalsaria; Dept-Eng Linux Driver
Cc: netdev; linux-kernel; Greg Marsden
Subject: [PATCH] qla3xxx: Ensure req_q_phy_addr writes to the register

Make sure req_q_phy_addr write to the register.

Signed-off-by Joe Jin <[email protected]>
Cc Ron Mercer <[email protected]>
Cc Jitendra Kalsaria <[email protected]>

---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++

1 file changed, 6 insertions(+)
drivers/net/ethernet/qlogic/qla3xxx.c +0 -0
index df09b1c..78b4cba 100644
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
 	qdev->req_q_size =
 	    (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));

drivers/net/ethernet/qlogic/qla3xxx.c static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev) · line 2536

Quoted 10 lines
drivers/net/ethernet/qlogic/qla3xxx.c +6 -0
 
+	/*
+	 * The barrier is required to ensure that req_q_phy_addr writes to
+	 * the memory.
+	 */
+	wmb();
+
 	qdev->req_q_virt_addr =
 	    pci_alloc_consistent(qdev->pdev,
 				 (size_t) qdev->req_q_size,

Your changes only take care of request queue but not response queue which also need barrier.

	qdev->req_q_size =
		(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));

	qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);

	wmb();

thanks,
Jiten

Signature · 1 line
1.7.11.7
author
#2 lore raw
Quoted 26 lines · Jitendra Kalsaria
Quoted 26 lines

-----Original Message-----
From: Joe Jin [mailto:[email protected]]
Sent: Tuesday, October 16, 2012 11:32 PM
To: Ron Mercer; Jitendra Kalsaria; Dept-Eng Linux Driver
Cc: netdev; linux-kernel; Greg Marsden
Subject: [PATCH] qla3xxx: Ensure req_q_phy_addr writes to the register

Make sure req_q_phy_addr write to the register.

Signed-off-by Joe Jin <[email protected]>
Cc Ron Mercer <[email protected]>
Cc Jitendra Kalsaria <[email protected]>

---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++

1 file changed, 6 insertions(+)
drivers/net/ethernet/qlogic/qla3xxx.c +0 -0
index df09b1c..78b4cba 100644
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
 	qdev->req_q_size =
 	    (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
Quoted 11 lines

drivers/net/ethernet/qlogic/qla3xxx.c static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev) · line 2536

Quoted 9 lines
drivers/net/ethernet/qlogic/qla3xxx.c +6 -0
+	/*
+	 * The barrier is required to ensure that req_q_phy_addr writes to
+	 * the memory.
+	 */
+	wmb();
+
 	qdev->req_q_virt_addr =
 	    pci_alloc_consistent(qdev->pdev,
 				 (size_t) qdev->req_q_size,

Your changes only take care of request queue but not response queue which also need barrier.

Jiten,

Thanks for review!
The barrier to make sure writel() call for req_q_phy_addr and rsp_q_phy_addr in ql_adapter_initialize(), so I think call once wmb() is enough but I need to update the comment, any idea?

Thanks,
Joe

Quoted 11 lines
	qdev->req_q_size =
		(u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));

	qdev->rsp_q_size = NUM_RSP_Q_ENTRIES * sizeof(struct net_rsp_iocb);

	wmb();

thanks,
Jiten

Signature · 4 lines
Oracle <http://www.oracle.com>
Joe Jin | Software Development Senior Manager | +8610.6106.5624
ORACLE | Linux and Virtualization
No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing
#3 lore raw
Quoted 38 lines
Quoted 26 lines
Quoted 26 lines

-----Original Message-----
From: Joe Jin [mailto:[email protected]]
Sent: Tuesday, October 16, 2012 11:32 PM
To: Ron Mercer; Jitendra Kalsaria; Dept-Eng Linux Driver
Cc: netdev; linux-kernel; Greg Marsden
Subject: [PATCH] qla3xxx: Ensure req_q_phy_addr writes to the register

Make sure req_q_phy_addr write to the register.

Signed-off-by Joe Jin <[email protected]>
Cc Ron Mercer <[email protected]>
Cc Jitendra Kalsaria <[email protected]>

---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++

1 file changed, 6 insertions(+)
drivers/net/ethernet/qlogic/qla3xxx.c +0 -0
index df09b1c..78b4cba 100644
@@ -2525,6 +2525,12 @@ static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev)
 	qdev->req_q_size =
 	    (u32) (NUM_REQ_Q_ENTRIES * sizeof(struct ob_mac_iocb_req));
Quoted 11 lines

drivers/net/ethernet/qlogic/qla3xxx.c static int ql_alloc_net_req_rsp_queues(struct ql3_adapter *qdev) · line 2536

Quoted 9 lines
drivers/net/ethernet/qlogic/qla3xxx.c +6 -0
+	/*
+	 * The barrier is required to ensure that req_q_phy_addr writes to
+	 * the memory.
+	 */
+	wmb();
+
 	qdev->req_q_virt_addr =
 	    pci_alloc_consistent(qdev->pdev,
 				 (size_t) qdev->req_q_size,

Your changes only take care of request queue but not response queue which also need barrier.

Quoted 6 lines

Jiten,

Thanks for review!
The barrier to make sure writel() call for req_q_phy_addr and rsp_q_phy_addr in ql_adapter_initialize(), so I think call once wmb() is enough but I need to update the comment, any idea?

Yes and something like "ensure request/response queue addr writes to the register"