Skip to contentSkip to conversation

can: Let Flexcan driver depend on platform support

PATCH In review Jan Kiszka 2 participants 3 messages Oct 17, 2012

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 can: Let Flexcan driver depend on platform support

Just like the Linux version does, let our RT Flexcan driver depend on CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms that actually support it.

---
 ksrc/drivers/can/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ksrc/drivers/can/Kconfig +1 -1
index 216b807..ce411dd 100644
@@ -80,7 +80,7 @@ config XENO_DRIVERS_CAN_VIRT
 	More ports can be enabled with the module parameter "devices".
 
 config XENO_DRIVERS_CAN_FLEXCAN
-	depends on XENO_DRIVERS_CAN && !XENO_DRIVERS_CAN_CALC_BITTIME_OLD
+	depends on XENO_DRIVERS_CAN && HAVE_CAN_FLEXCAN && !XENO_DRIVERS_CAN_CALC_BITTIME_OLD
 	tristate "Freescale FLEXCAN based chips"
 	help
 
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 3 lines · Jan Kiszka

Just like the Linux version does, let our RT Flexcan driver depend on CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms that actually support it.

Do all old kernels for CPUs which have a flexcan controller have this symbol defined?

Signature · 1 line
                                                                Gilles.
author
#2 lore raw
Quoted 9 lines · Gilles Chanteperdrix
Quoted 3 lines · Jan Kiszka

Just like the Linux version does, let our RT Flexcan driver depend on CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms that actually support it.

Do all old kernels for CPUs which have a flexcan controller have this symbol defined?

That's a question for Wolfgang. We briefly discussed this yesterday, and that dependency appeared reasonable on first glance.

The platform has to provide at least CONFIG_OF. So that could be plan B in case HAVE_CAN_FLEXCAN is too strict.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux