Skip to contentSkip to conversation

toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

PATCH New Thomas Petazzoni 4 participants 4 messages Oct 17, 2012 – Oct 18, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng backend generates toolchains that have a prefix inconsistent with what Buildroot expects. Buildroot expects a "buildroot" vendor name, while Crosstool-NG builds toolchain with the "unknown" vendor name.

This is causing build failure such as:

http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Fix this by changing the vendor part of the tuple used by Crosstool-NG to "buildroot".

---
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
toolchain/toolchain-crosstool-ng/crosstool-ng.mk +1 -1
index d18f5d5..e46bb20 100644
@@ -201,7 +201,7 @@ CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
 CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
-CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
 ifneq ($(call qstrip,$(BR2_USE_MMU)),)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

Thomas, All,

Quoted 5 lines · On Wednesday 17 October 2012 Thomas Petazzoni wrote:

Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng backend generates toolchains that have a prefix inconsistent with what Buildroot expects. Buildroot expects a "buildroot" vendor name, while Crosstool-NG builds toolchain with the "unknown" vendor name.

Quoted 8 lines

This is causing build failure such as:

http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Fix this by changing the vendor part of the tuple used by Crosstool-NG to "buildroot".

Quoted 26 lines
---
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
toolchain/toolchain-crosstool-ng/crosstool-ng.mk +1 -1
index d18f5d5..e46bb20 100644
@@ -201,7 +201,7 @@ CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
 CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
-CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
 ifneq ($(call qstrip,$(BR2_USE_MMU)),)
Signature · 6 lines
1.7.9.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

Quoted 8 lines · Yann E. MORIN
Quoted 7 lines · On Wednesday 17 October 2012 Thomas Petazzoni wrote:
Quoted 7 lines

Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng backend generates toolchains that have a prefix inconsistent with what Buildroot expects. Buildroot expects a "buildroot" vendor name, while Crosstool-NG builds toolchain with the "unknown" vendor name.

This is causing build failure such as:

Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
    http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Fix this by changing the vendor part of the tuple used by Crosstool-NG to "buildroot".

I had the very same patch lined up but forgot to commit and mail it...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng Thomas> backend generates toolchains that have a prefix inconsistent with what Thomas> Buildroot expects. Buildroot expects a "buildroot" vendor name, while Thomas> Crosstool-NG builds toolchain with the "unknown" vendor name.

Thomas> This is causing build failure such as:

Thomas> http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Thomas> Fix this by changing the vendor part of the tuple used by Crosstool-NG Thomas> to "buildroot".

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard