ARM: OMAP2+: clockdomain: Fix OMAP4 ISS clk domain to support only SWSUP
PATCH 1/1 ARM: OMAP2+: clockdomain: Fix OMAP4 ISS clk domain to support only SWSUP
From: Miguel Vadillo <[email protected]>
Since CAM domain (ISS) has no module wake-up dependency with any other clock domain of the device and the dynamic dependency from L3_main_2 is always disabled, the domain needs to be in force wakeup in order to be able to access it for configure (sysconfig) it or use it.
Also since there is no clock in the domain managed automatically by the hardware, there is no use to configure automatic clock domain transition. SW should keep the SW_WKUP domain transition as long as a module in the domain is required to be functional.
---
Hi Tony,
Here is a fix that Miguel sent me some time back and that I forgot until I face the crash again while trying to enable the ISS for test.
Regards,
Benoit
arch/arm/mach-omap2/clockdomains44xx_data.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0
b/arch/arm/mach-omap2/clockdomains44xx_data.c
index b56d06b..95192a0 100644
arch/arm/mach-omap2/clockdomains44xx_data.c +1 -1
@@ -359,7 +359,7 @@ static struct clockdomain iss_44xx_clkdm = { .clkdm_offs = OMAP4430_CM2_CAM_CAM_CDOFFS, .wkdep_srcs = iss_wkup_sleep_deps, .sleepdep_srcs = iss_wkup_sleep_deps, - .flags = CLKDM_CAN_HWSUP_SWSUP, + .flags = CLKDM_CAN_SWSUP, };static struct clockdomain l3_dss_44xx_clkdm = {
Signature · 1 line
1.7.0.4
Paul Walmsley
maintainerPATCH 1/1 ARM: OMAP2+: clockdomain: Fix OMAP4 ISS clk domain to support only SWSUP
Quoted 8 lines · Benoit Cousson
From: Miguel Vadillo <[email protected]>
Since CAM domain (ISS) has no module wake-up dependency with any other clock domain of the device and the dynamic dependency from
L3_main_2is always disabled, the domain needs to be in force wakeup in order to be able to access it for configure (sysconfig) it or use it.
Quoted 8 lines
Also since there is no clock in the domain managed automatically by the hardware, there is no use to configure automatic clock domain transition. SW should keep the
SW_WKUPdomain transition as long as a module in the domain is required to be functional.Signed-off-by Miguel Vadillo <[email protected]>Signed-off-by Benoit Cousson <[email protected]>
Thanks queued for 3.7-rc.
- Paul