Change deprecated gnome_role to new gnome_role_gconfd

PATCH New Dominick Grift 2 participants 6 messages Oct 9, 2012 – Oct 19, 2012

lore

Share & tools

lore

Dominick Grift

author

2012-10-09 15:50 UTC #0 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Signed-off-by Dominick Grift <[email protected]>

policy/modules/roles/staff.te +1 -1

index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`

policy/modules/roles/sysadm.te +1 -1

index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`

policy/modules/roles/unprivuser.te +1 -1

index 9f6d4c3..e354193 100644
@@ -66,7 +66,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')
 
 	optional_policy(`

Christopher J. PeBenito

2012-10-10 13:35 UTC #1 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Quoted 32 lines · Dominick Grift

Signed-off-by Dominick Grift <[email protected]>

policy/modules/roles/staff.te +1 -1

index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`

policy/modules/roles/sysadm.te +1 -1

index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`

policy/modules/roles/unprivuser.te +0 -0

index 9f6d4c3..e354193 100644

policy/modules/roles/unprivuser.te line 72

Quoted 8 lines

policy/modules/roles/unprivuser.te +1 -1

@@ -66,7 +66,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')
 
 	optional_policy(`

Why was gnome_role() deprecated in the first place?

Signature · 3 lines

Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

Dominick Grift

author

2012-10-10 14:10 UTC #2 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Quoted 35 lines · Christopher J. PeBenito

Quoted 33 lines · Dominick Grift

Signed-off-by Dominick Grift <[email protected]>

policy/modules/roles/staff.te +1 -1

index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`

policy/modules/roles/sysadm.te +1 -1

index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`

policy/modules/roles/unprivuser.te +0 -0

index 9f6d4c3..e354193 100644
@@ -66,7 +66,7 @@
 	')

Quoted 9 lines

policy/modules/roles/unprivuser.te line 72
Quoted 6 lines
policy/modules/roles/unprivuser.te +1 -1
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')
 
 	optional_policy(`
Why was gnome_role() deprecated in the first place?

I just decided that this would possibly give more flexibility later.

Gnome is a big project and one might want to enforce restrictions on parts of it rather than all of it in some cases.

But the main reason is because it is a bit cleaner. Some gnome apps need to be prefixed while others do not.

Of course you could just ignore the prefix param for apps that do not need it but i decided to do it like this.

So its basically a combination of the two considerations above

It guess "for practical reasons"

Dominick Grift

author

2012-10-10 14:22 UTC #3 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Quoted 42 lines · Dominick Grift

Quoted 40 lines · Christopher J. PeBenito

Quoted 39 lines · Dominick Grift

Signed-off-by Dominick Grift <[email protected]>

policy/modules/roles/staff.te +1 -1

index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`

policy/modules/roles/sysadm.te +1 -1

index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`

policy/modules/roles/unprivuser.te +1 -1

index 9f6d4c3..e354193 100644
@@ -66,7 +66,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')

Quoted 4 lines

Quoted 4 lines
policy/modules/roles/unprivuser.te line 72
Quoted 1 line
policy/modules/roles/unprivuser.te +0 -0
 	optional_policy(`
Why was gnome_role() deprecated in the first place?

There is now also a gnome_role_gkeyringd() but its not called yet because its a work in progress ( it depends on freedeskop config/cache/data dirs)

So for example

Fedora will probably call gnome_role_gkeyringd() but not gnome_role_gconfd()

If you pile them all in one huge template then that allows for less flexibility

Christopher J. PeBenito

2012-10-19 13:17 UTC #4 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Quoted 54 lines · Dominick Grift

Quoted 42 lines · Dominick Grift
Quoted 40 lines · Christopher J. PeBenito
Quoted 39 lines · Dominick Grift
Signed-off-by Dominick Grift <[email protected]>
policy/modules/roles/staff.te +1 -1
index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`
policy/modules/roles/sysadm.te +1 -1
index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`
policy/modules/roles/unprivuser.te +1 -1
index 9f6d4c3..e354193 100644
@@ -66,7 +66,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')
 
Quoted 4 lines
Quoted 4 lines
policy/modules/roles/unprivuser.te line 72
Quoted 1 line
policy/modules/roles/unprivuser.te +0 -0
 	optional_policy(`
Why was gnome_role() deprecated in the first place?
There is now also a gnome_role_gkeyringd() but its not called yet because its a work in progress ( it depends on freedeskop config/cache/data dirs)

Quoted 7 lines

So for example
Fedora will probably call gnome_role_gkeyringd() but not gnome_role_gconfd()
If you pile them all in one huge template then that allows for less flexibility

No. I think it abstracts the gnome complexities away from other modules, and puts it where it rightly belongs, in the gnome module.

Signature · 3 lines

Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

Dominick Grift

author

2012-10-19 13:28 UTC #5 lore raw

PATCH 1/1 Change deprecated gnome_role to new gnome_role_gconfd

Quoted 57 lines · Christopher J. PeBenito

Quoted 56 lines · Dominick Grift
Quoted 42 lines · Dominick Grift
Quoted 40 lines · Christopher J. PeBenito
Quoted 39 lines · Dominick Grift
Signed-off-by Dominick Grift <[email protected]>
policy/modules/roles/staff.te +1 -1
index e5aee97..2d1520d 100644
@@ -93,7 +93,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(staff_r, staff_t)
+		gnome_role_gconfd(staff_r, staff_t)
 	')
 
 	optional_policy(`
policy/modules/roles/sysadm.te +1 -1
index 44c198a..1803cfd 100644
@@ -459,7 +459,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(sysadm_r, sysadm_t)
+		gnome_role_gconfd(sysadm_r, sysadm_t)
 	')
 
 	optional_policy(`
policy/modules/roles/unprivuser.te +1 -1
index 9f6d4c3..e354193 100644
@@ -66,7 +66,7 @@
 	')
 
 	optional_policy(`
-		gnome_role(user_r, user_t)
+		gnome_role_gconfd(user_r, user_t)
 	')
 
Quoted 4 lines
Quoted 4 lines
policy/modules/roles/unprivuser.te line 72
Quoted 1 line
policy/modules/roles/unprivuser.te +0 -0
 	optional_policy(`
Why was gnome_role() deprecated in the first place?
There is now also a gnome_role_gkeyringd() but its not called yet because its a work in progress ( it depends on freedeskop config/cache/data dirs)
So for example

Quoted 8 lines

Quoted 5 lines
Fedora will probably call gnome_role_gkeyringd() but not gnome_role_gconfd()
If you pile them all in one huge template then that allows for less flexibility
No. I think it abstracts the gnome complexities away from other modules, and puts it where it rightly belongs, in the gnome module.

What do you mean? it is in the gnome module

its just a different template...

We can use the gnome_role later to compile the seperate templates in the one for people that want to calls them all

But we need to support people that are only interested in calling a single template