lcdapi: new package

From: Simon Dawson<[email protected]>

Signed-off-by Simon Dawson<[email protected]>

package/lcdapi/lcdapi-make-toString-static.patch new file +6 -0

new file mode 100644
index 0000000..0ef95fc
@@ -0,0 +1,19 @@
+make the toString function defined in the LCDCallback.h header into a static
+function, to fix link-time errors like the following.
+
+  multiple definition of `toString(char)'
+
+Signed-off-by: Simon Dawson<[email protected]>

package/lcdapi/lcdapi-make-toString-static.patch new file +3 -0

+ {
+   std::string s(1, (char)t);
+   return s;

package/lcdapi/lcdapi.mk new file +0 -0

new file mode 100644
index 0000000..37e276c

package/lcdapi/lcdapi.mk new file +7 -0

+
+HOST_LCDAPI_MAKE_OPT = \
+	$(HOST_CONFIGURE_OPTS) \
+	LD="$(HOSTCXX)" \
+	LDFLAGS="$(HOST_LDFLAGS) -shared"
+
+define LCDAPI_BUILD_CMDS

package/lcdapi/lcdapi.mk new file +34 -0

+	done
+endef
+
+define DO_LCDAPI_UNINSTALL
+	$(RM) $(1)/usr/lib/liblcdapi.so
+	$(RM) -r $(1)/usr/include/lcdapi
+endef
+
+define HOST_LCDAPI_INSTALL_CMDS
+	$(call DO_LCDAPI_INSTALL,$(HOST_DIR))
+endef
+
+define LCDAPI_INSTALL_STAGING_CMDS
+	$(call DO_LCDAPI_INSTALL,$(STAGING_DIR))
+endef
+
+define LCDAPI_INSTALL_TARGET_CMDS
+	$(call DO_LCDAPI_INSTALL,$(TARGET_DIR))
+endef
+
+define LCDAPI_UNINSTALL_STAGING_CMDS
+	$(call DO_LCDAPI_UNINSTALL,$(STAGING_DIR))
+endef
+
+define LCDAPI_UNINSTALL_TARGET_CMDS
+	$(call DO_LCDAPI_UNINSTALL,$(TARGET_DIR))
+endef
+
+define LCDAPI_CLEAN_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) $(LCDAPI_MAKE_OPT) -C $(@D) clean
+endef
+
+$(eval $(generic-package))
+$(eval $(host-generic-package))

Making it inline sounds more appropriate.

BTW, did you upstream the patches?

Quoted 1 line

+LCDAPI_DEPENDENCIES = host-lcdapi

Why is this needed? Or rather: I can build without this.
If it is not needed, the whole host-lcdapi can be removed BTW.

package/lcdapi/lcdapi.mk line 17

Quoted 4 lines

package/lcdapi/lcdapi.mk new file +4 -0

+LCDAPI_MAKE_OPT = \
+       $(TARGET_CONFIGURE_OPTS) \
+       LD="$(TARGET_CXX)" \
+       LDFLAGS="$(TARGET_LDFLAGS) -shared"

It would make sense to also add CC="$(TARGET_CXX)" (although not strictly
necessary, because gcc recognizes the .cpp extension).

More importantly, the CFLAGS overrides the CFLAGS of lcdapi's
Makefile, and that contains the all-important -fPIC. I wonder how you got it built without that... So either:

- Set CFLAGS to "$(TARGET_CFLAGS) -fPIC"
- Patch the Makefile to append to CFLAGS
- Set CC to "$(TARGET_CXX) $(TARGET_CFLAGS)" and leave CFLAGS alone

Finally, it would make sense to call it LCDAPI_MAKE_OPTS,
similar to TARGET_CONFIGURE_OPTS.

We would typically use

        $(INSTALL) -m 0755 -D $(@D)/lib/liblcdapi.so $(1)/usr/lib

(which does the mkdir and the install in one shot).

But wouldn't it be cleaner to add (and upstream) an 'install' target
to the Makefile?

Hi Arnout. Thanks for taking the time to review this.

Quoted 1 line · Arnout Vandecappelle

Making it inline sounds more appropriate.

Okay; will do so.

Quoted 1 line

BTW, did you upstream the patches?

Unfortunately, the upstream project is no longer being actively maintained; I have attempted to contact the author, but have had no response.

I have actually started work on a fork of the project at
https://github.com/spdawson/lcdapi; but I thought it best to use the original source for the Buildroot package, at least in the first instance.

Quoted 8 lines

package/lcdapi/lcdapi.mk line 17

Quoted 4 lines

package/lcdapi/lcdapi.mk new file +4 -0

+LCDAPI_MAKE_OPT = \
+       $(TARGET_CONFIGURE_OPTS) \
+       LD="$(TARGET_CXX)" \
+       LDFLAGS="$(TARGET_LDFLAGS) -shared"

It would make sense to also add CC="$(TARGET_CXX)" (although not strictly
necessary, because gcc recognizes the .cpp extension).

Okay; will do.

Quoted 7 lines

More importantly, the CFLAGS overrides the CFLAGS of lcdapi's
Makefile, and that contains the all-important -fPIC. I wonder how you got it built without that... So either:

- Set CFLAGS to "$(TARGET_CFLAGS) -fPIC"
- Patch the Makefile to append to CFLAGS
- Set CC to "$(TARGET_CXX) $(TARGET_CFLAGS)" and leave CFLAGS alone

Okay, will do.

Quoted 2 lines

Finally, it would make sense to call it LCDAPI_MAKE_OPTS,
similar to TARGET_CONFIGURE_OPTS.

Okay, will do.

Quoted 3 lines

We would typically use

         $(INSTALL) -m 0755 -D $(@D)/lib/liblcdapi.so $(1)/usr/lib

(which does the mkdir and the install in one shot).

Okay, will do.

Quoted 2 lines

But wouldn't it be cleaner to add (and upstream) an 'install' target
to the Makefile?

Yes, okay.

Sorry that I'm giving you more work :-)