Skip to contentSkip to conversation

drivers/built-in.o: In function `qcom_smp2p_intr':

PATCH In review Arnd Bergmann 1 participant 2 messages Nov 20, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/built-in.o: In function `qcom_smp2p_intr':

The newly added smp2p and smsm drivers cannot be loadable modules but depend on smem, which can be, and that causes a link error:

:(.text+0xa6e68): undefined reference to qcom_smem_get' drivers/built-in.o: In function qcom_smp2p_probe':
:(.text+0xa7320): undefined reference to qcom_smem_alloc' :(.text+0xa736c): undefined reference to qcom_smem_get' drivers/built-in.o: In function `qcom_smsm_probe':
:(.text+0xa7b34): undefined reference to `qcom_smem_get'

This marks all the drivers as 'tristate' to make the Kconfig dependency resolution work properly.

Fixes dbb04bd7122f ("soc: qcom: smp2p: Qualcomm Shared Memory Point to Point")
Fixes d7387fc6add4 ("soc: qcom: smsm: Add driver for Qualcomm SMSM")

---
This showed up on arm allmodconfig with linux-next today, please apply or fold into the original patches.

drivers/soc/qcom/Kconfig +2 -2
index b57be7ab50b6..57b7145358e7 100644
@@ -54,7 +54,7 @@ config QCOM_SMEM_STATE
 	bool
 
 config QCOM_SMP2P
-	bool "Qualcomm Shared Memory Point to Point support"
+	tristate "Qualcomm Shared Memory Point to Point support"
 	depends on QCOM_SMEM
 	select QCOM_SMEM_STATE
 	help
@@ -62,7 +62,7 @@ config QCOM_SMP2P
 	  protocol.
 
 config QCOM_SMSM
-	bool "Qualcomm Shared Memory State Machine"
+	tristate "Qualcomm Shared Memory State Machine"
 	depends on QCOM_SMEM
 	select QCOM_SMEM_STATE
 	help
#1 lore raw
Quoted 3 lines · On Friday 20 November 2015 10:43:00 Arnd Bergmann wrote:

The newly added smp2p and smsm drivers cannot be loadable modules but depend on smem, which can be, and that causes a link error:

Sorry, $SUBJECT is wrong, I'll resend.

Arnd