Skip to contentSkip to conversation

net/mlx5: reduce log level in hlist registration

PATCH Applied Matan Azrad 4 participants 4 messages Nov 23, 2020 – Nov 24, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: reduce log level in hlist registration

In mlx5 internal hash list tool, there is a log print when an entry allocation is failed: Can't allocate hash list entry.

Some initialization checks triggers hash list registration in order to check some capabilities. Here, the failure in registration doesn't lead to failure in the initialization flow, that is why the log level can be lower.

Move the entry allocation failure log to debug level.

---
 drivers/net/mlx5/mlx5_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_utils.c +1 -1
index 9889437..848d108 100644
@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
 	entry = h->cb_create(h, key, ctx);
 	if (!entry) {
 		rte_errno = ENOMEM;
-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h->name);
 		goto done;
 	}
 	entry->key = key;
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw

Regards,
Asaf Penso

Quoted 10 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Matan Azrad
Sent: Monday, November 23, 2020 5:57 PM
To: Slava Ovsiienko <[email protected]>
Cc: [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>
Subject: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration

In mlx5 internal hash list tool, there is a log print when an entry allocation is
failed: Can't allocate hash list entry.

Quoted 7 lines

Some initialization checks triggers hash list registration in order to check some capabilities. Here, the failure in registration doesn't lead to failure in the initialization flow, that is why the log level can be lower.

Move the entry allocation failure log to debug level.

Quoted 20 lines

---
drivers/net/mlx5/mlx5_utils.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_utils.c +1 -1
index 9889437..848d108 100644
@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
 	entry = h->cb_create(h, key, ctx);
 	if (!entry) {
 		rte_errno = ENOMEM;
-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h-
 >name);
 		goto done;
 	}
	entry->key = key;

--
1.8.3.1

Acked-by on v1 1/1
#2 lore raw
In reply to Matan Azrad
Quoted 10 lines

-----Original Message-----
From: Matan Azrad <[email protected]>
Sent: Monday, November 23, 2020 17:57
To: Slava Ovsiienko <[email protected]>
Cc: [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>
Subject: [PATCH] net/mlx5: reduce log level in hlist registration

In mlx5 internal hash list tool, there is a log print when an entry allocation is
failed: Can't allocate hash list entry.

Quoted 7 lines

Some initialization checks triggers hash list registration in order to check some capabilities. Here, the failure in registration doesn't lead to failure in the initialization flow, that is why the log level can be lower.

Move the entry allocation failure log to debug level.

#3 lore raw
Quoted 11 lines
Quoted 10 lines

In mlx5 internal hash list tool, there is a log print when an entry allocation is
failed: Can't allocate hash list entry.

Some initialization checks triggers hash list registration in order to check some capabilities. Here, the failure in registration doesn't lead to failure in the initialization flow, that is why the log level can be lower.

Move the entry allocation failure log to debug level.

Applied, thanks