ARM: dma-mapping: support debug_dma_mapping_error
PATCH 1/1 ARM: dma-mapping: support debug_dma_mapping_error
Without the patch, kind of below warning will be dumped if DMA-API debug is enabled:
[ 11.069763] ------------[ cut here ]------------ [ 11.074645] WARNING: at lib/dma-debug.c:948 check_unmap+0x770/0x860() [ 11.081420] ehci-omap ehci-omap.0: DMA-API: device driver failed to check map error[device address=0x0000000 0adb78e80] [size=8 bytes] [mapped as single] [ 11.095611] Modules linked in:
--- arch/arm/include/asm/dma-mapping.h | 1 + 1 file changed, 1 insertion(+)
arch/arm/include/asm/dma-mapping.h +1 -0
@@ -91,6 +91,7 @@ static inline dma_addr_t virt_to_dma(struct device *dev, void *addr)*/ static inline int dma_mapping_error (struct device *dev,dma_addr_t dma_addr) { +debug_dma_mapping_error (dev, dma_addr);return dma_addr ==DMA_ERROR_CODE ; }
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: dma-mapping: support debug_dma_mapping_error
Hello,
Quoted 10 lines · Ming Lei
Without the patch, kind of below warning will be dumped if DMA-API debug is enabled:
[ 11.069763] ------------[ cut here ]------------ [ 11.074645] WARNING: at lib/dma-debug.c:948 check_unmap+0x770/0x860() [ 11.081420] ehci-omap ehci-omap.0: DMA-API: device driver failed to check map error[device address=0x0000000 0adb78e80] [size=8 bytes] [mapped as single] [ 11.095611] Modules linked in:
Quoted 3 lines
Cc Russell King <[email protected]>Cc Marek Szyprowski <[email protected]>Signed-off-by Ming Lei <[email protected]>
Thanks for the patch, I've applied it to my kernel tree.
Quoted 1 line
...
Best regards
Signature · 2 lines
Marek Szyprowski Samsung Poland R&D Center
PATCH 1/1 ARM: dma-mapping: support debug_dma_mapping_error
In reply to Ming LeiQuoted 10 lines · Ming Lei
Without the patch, kind of below warning will be dumped if DMA-API debug is enabled:
[ 11.069763] ------------[ cut here ]------------ [ 11.074645] WARNING: at lib/dma-debug.c:948 check_unmap+0x770/0x860() [ 11.081420] ehci-omap ehci-omap.0: DMA-API: device driver failed to check map error[device address=0x0000000 0adb78e80] [size=8 bytes] [mapped as single] [ 11.095611] Modules linked in:
Quoted 3 lines
Cc Russell King <[email protected]>Cc Marek Szyprowski <[email protected]>Signed-off-by Ming Lei <[email protected]>
Would you mind explaining why you think it's fine to send a patch for the mainline kernel adding a function call to a header file which is not even in the mainline kernel?
My guess is that the Canonical kernel has some additional checking here which mainline kernels don't have, which means your patch should never have been submitted (or even applied.)
On Marek's side, why didn't you try to build your tree at least once in the last 3 days before pushing this patch to Linus?
PATCH 1/1 ARM: dma-mapping: support debug_dma_mapping_error
Quoted 11 lines · Russell King - ARM Linux
Quoted 10 lines · Ming Lei
Without the patch, kind of below warning will be dumped if DMA-API debug is enabled:
[ 11.069763] ------------[ cut here ]------------ [ 11.074645] WARNING: at lib/dma-debug.c:948 check_unmap+0x770/0x860() [ 11.081420] ehci-omap ehci-omap.0: DMA-API: device driver failed to check map error[device address=0x0000000 0adb78e80] [size=8 bytes] [mapped as single] [ 11.095611] Modules linked in:
Quoted 7 lines
Quoted 3 lines
Cc Russell King <[email protected]>Cc Marek Szyprowski <[email protected]>Signed-off-by Ming Lei <[email protected]>Would you mind explaining why you think it's fine to send a patch for the mainline kernel adding a function call to a header file which is not even in the mainline kernel?
Sorry, I should have made it explicitly that the patch is against -next tree.
Thanks,
--
Ming Lei