Bluetooth: Add support for BCM20702A0 [0b05, 17b5]

PATCH In review Jeff Cook 3 participants 9 messages Oct 24, 2012 – Nov 19, 2012 Bluetooth drivers

lore

Share & tools

lore

Jeff Cook

author

2012-10-24 09:29 UTC #0 lore raw

PATCH 1/1 Bluetooth: Add support for BCM20702A0 [0b05, 17b5]

Hello all,

Please see included patch. First-time submitter so let me know if I did something wrong.

Thanks,
Jeff
--------------------

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

drivers/bluetooth/btusb.c +1 -0

index 654e248..1d7b126 100644
@@ -96,6 +96,7 @@ static struct usb_device_id btusb_table[] = {
 	{ USB_DEVICE(0x0c10, 0x0000) },
 
 	/* Broadcom BCM20702A0 */
+	{ USB_DEVICE(0x0b05, 0x17b5) },
 	{ USB_DEVICE(0x0489, 0xe042) },
 	{ USB_DEVICE(0x413c, 0x8197) },

Signature · 1 line

1.8.0

Gustavo Padovan

2012-10-24 12:11 UTC #1 lore raw

Hi Jeff,

Quoted 4 lines · Jeff Cook

Hello all,
Please see included patch. First-time submitter so let me know if I did something wrong.

Your patch is good, but you need to improve the way you submit it. We recommend using 'git send-email' like this:

$ git send-email HEAD~1..HEAD

For sending the patch on the top of tree. You can also do combined use of 'git format-patch' and 'git send-email' in case you want to add some message or to your patch like the first-time submitter message you did here and these messages needs to be added...

Quoted 20 lines

Thanks,
Jeff
--------------------

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Quoted 1 line

---

... after these 3 dashes lines so they don't go the final commit when I apply your patch.

Gustavo

Anderson Lizardo

2012-10-24 12:20 UTC #2 lore raw

In reply to Jeff Cook

Hi Jeff,

Quoted 4 lines · Jeff Cook

Hello all,
Please see included patch. First-time submitter so let me know if I did something wrong.

Just one more suggestion (adding to Gustavo's comments), you may want to read:

http://www.kernel.org/doc/Documentation/SubmittingPatches

Specially sections 12 and 15.

Best Regards,

Signature · 3 lines

Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Jeff Cook

author

2012-10-25 19:17 UTC #3 lore raw

Quoted 5 lines · Anderson Lizardo

Hi Jeff,
Quoted 2 lines · Jeff Cook
Hello all,

Quoted 8 lines

Quoted 2 lines
Please see included patch. First-time submitter so let me know if I did something wrong.
Just one more suggestion (adding to Gustavo's comments), you may want to read:
http://www.kernel.org/doc/Documentation/SubmittingPatches
Specially sections 12 and 15.

Thanks for the help everyone. I did skim SubmittingPatches prior to submission, but dropped off before sections 12 and 15; the information seemed outdated since it made no mention of git by the time I stopped reading (around section 9 or so), so I looked elsewhere.

I will resubmit according to the information in Section 15. Do I need to add something like "try 2" to the patch's subject line, or is it okay without that?

Anderson Lizardo

2012-10-26 12:49 UTC #4 lore raw

Hi Jeff,

Quoted 8 lines · Jeff Cook

Thanks for the help everyone. I did skim SubmittingPatches prior to submission, but dropped off before sections 12 and 15; the information seemed outdated since it made no mention of git by the time I stopped reading (around section 9 or so), so I looked elsewhere.
I will resubmit according to the information in Section 15. Do I need to add something like "try 2" to the patch's subject line, or is it okay without that?

Usually I generate a new patch with "git format-patch HEAD^" and edit the "[PATCH]" prefix to become "[PATCH v2]" and resend the patch using:

git send-email --to linux-bluetooth@... --in-reply-to AAA 0001-name-of-the-patch.patch

where "AAA" is the "Message-ID" of the original patch (as seen in the mail headers, e.g. [email protected] for your original patch). and "0001-name-of-the-patch.patch" is the filename for the patch created by git format-patch.

Hope that helps,

Signature · 3 lines

Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Jeff Cook

author

2012-10-27 11:01 UTC #5 lore raw

PATCH 1/1 Bluetooth: Add support for BCM20702A0 [0b05, 17b5]

In reply to Jeff Cook

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Signed-off-by Jeff Cook <[email protected]>

---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

drivers/bluetooth/btusb.c +1 -0

index 654e248..1d7b126 100644
@@ -96,6 +96,7 @@ static struct usb_device_id btusb_table[] = {
 	{ USB_DEVICE(0x0c10, 0x0000) },
 
 	/* Broadcom BCM20702A0 */
+	{ USB_DEVICE(0x0b05, 0x17b5) },
 	{ USB_DEVICE(0x0489, 0xe042) },
 	{ USB_DEVICE(0x413c, 0x8197) },

Signature · 1 line

1.8.0

Gustavo Padovan

2012-10-31 18:15 UTC #6 lore raw

Hi Jeff,

Quoted 26 lines · Jeff Cook

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Signed-off-by Jeff Cook <[email protected]>

---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

drivers/bluetooth/btusb.c +0 -0

index 654e248..1d7b126 100644

drivers/bluetooth/btusb.c static struct usb_device_id btusb_table[] = { · line 101

Quoted 6 lines

drivers/bluetooth/btusb.c +1 -0

@@ -96,6 +96,7 @@ static struct usb_device_id btusb_table[] = {
 	{ USB_DEVICE(0x0c10, 0x0000) },
 
 	/* Broadcom BCM20702A0 */
+	{ USB_DEVICE(0x0b05, 0x17b5) },
 	{ USB_DEVICE(0x0489, 0xe042) },
 	{ USB_DEVICE(0x413c, 0x8197) },

This patch doesn't apply on bluetooth.git can you please rebase it on of it. You can find the bluetooth.git tree at:

http://git.kernel.org/?p=linux/kernel/git/bluetooth/bluetooth.git;a=summary

Gustavo

Jeff Cook

author

2012-11-09 23:39 UTC #7 lore raw

PATCH v2 1/1 Bluetooth: Add support for BCM20702A0 [0b05, 17b5]

In reply to Jeff Cook

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Signed-off-by Jeff Cook <[email protected]>

---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

drivers/bluetooth/btusb.c +1 -0

index ee82f2f..a1d4ede 100644
@@ -96,6 +96,7 @@ static struct usb_device_id btusb_table[] = {
 	{ USB_DEVICE(0x0c10, 0x0000) },
 
 	/* Broadcom BCM20702A0 */
+	{ USB_DEVICE(0x0b05, 0x17b5) },
 	{ USB_DEVICE(0x04ca, 0x2003) },
 	{ USB_DEVICE(0x0489, 0xe042) },
 	{ USB_DEVICE(0x413c, 0x8197) },

Signature · 3 lines

Hi Gustavo,

Here is the rebased patch. Sorry for the delay getting this out.

Gustavo Padovan

2012-11-19 21:41 UTC #8 lore raw

Hi Jeff,

Quoted 16 lines · Jeff Cook

Vendor-specific ID for BCM20702A0.
Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V Deluxe.

T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17b5 Rev=01.12
S:  Manufacturer=Broadcom Corp
S:  Product=BCM20702A0
S:  SerialNumber=94DBC98AC113
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)

Quoted 4 lines

Signed-off-by Jeff Cook <[email protected]>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

Patch has been applied to bluetooth-next. Thanks.

Gustavo