Skip to contentSkip to conversation

arm: bcm2835: enable proc and sysfs in defconfig

PATCH New Thomas Petazzoni 3 participants 4 messages Oct 27, 2012 – Oct 28, 2012

Subsystems (3)
Arm (32-bit) Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 arm: bcm2835: enable proc and sysfs in defconfig

For some reason, support for proc and sysfs is currently disabled in the bcm2835_defconfig, even though those filesystems are quite essential even for very basic Linux userspace. As most defconfig have them enabled by default, enable them as well in bcm2835_defconfig.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 arch/arm/configs/bcm2835_defconfig |    2 --
 1 file changed, 2 deletions(-)
arch/arm/configs/bcm2835_defconfig +0 -2
index 7aea702..74e27f0 100644
@@ -66,8 +66,6 @@ CONFIG_TTY_PRINTK=y
 # CONFIG_FILE_LOCKING is not set
 # CONFIG_DNOTIFY is not set
 # CONFIG_INOTIFY_USER is not set
-# CONFIG_PROC_FS is not set
-# CONFIG_SYSFS is not set
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_PRINTK_TIME=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
Signature · 1 line
1.7.9.5
Applied
#1 lore raw

PATCH 1/1 arm: bcm2835: enable proc and sysfs in defconfig

Quoted 4 lines · Thomas Petazzoni

For some reason, support for proc and sysfs is currently disabled in the bcm2835_defconfig, even though those filesystems are quite essential even for very basic Linux userspace. As most defconfig have them enabled by default, enable them as well in bcm2835_defconfig.

How silly of me; I had this as part of a local change for testing, but hadn't made a patch to add it to the defconfig upstream.

Applied to bcm2835's for-3.8/defconfig branch. Thanks.

#2 lore raw

PATCH 1/1 arm: bcm2835: enable proc and sysfs in defconfig

In reply to Thomas Petazzoni

Hello.

Quoted 15 lines · Thomas Petazzoni

For some reason, support for proc and sysfs is currently disabled in the bcm2835_defconfig, even though those filesystems are quite essential even for very basic Linux userspace. As most defconfig have them enabled by default, enable them as well in bcm2835_defconfig.

Signed-off-by Thomas Petazzoni <[email protected]>
---
  arch/arm/configs/bcm2835_defconfig |    2 --
  1 file changed, 2 deletions(-)
arch/arm/configs/bcm2835_defconfig +0 -0
index 7aea702..74e27f0 100644

arch/arm/configs/bcm2835_defconfig CONFIG_TTY_PRINTK=y · line 70

Quoted 5 lines
arch/arm/configs/bcm2835_defconfig +0 -2
@@ -66,8 +66,6 @@ CONFIG_TTY_PRINTK=y
  # CONFIG_FILE_LOCKING is not set
  # CONFIG_DNOTIFY is not set
  # CONFIG_INOTIFY_USER is not set
-# CONFIG_PROC_FS is not set
-# CONFIG_SYSFS is not set

Hm, I don't see where are you enabling them... So I miss something?

WBR, Sergei

author
#3 lore raw

PATCH 1/1 arm: bcm2835: enable proc and sysfs in defconfig

Dear Sergei Shtylyov,

Quoted 4 lines · Sergei Shtylyov
Quoted 4 lines
arch/arm/configs/bcm2835_defconfig +0 -0
index 7aea702..74e27f0 100644
Quoted 8 lines

arch/arm/configs/bcm2835_defconfig CONFIG_TTY_PRINTK=y · line 70

Quoted 6 lines
arch/arm/configs/bcm2835_defconfig +0 -2
@@ -66,8 +66,6 @@ CONFIG_TTY_PRINTK=y
  # CONFIG_FILE_LOCKING is not set
  # CONFIG_DNOTIFY is not set
  # CONFIG_INOTIFY_USER is not set
-# CONFIG_PROC_FS is not set
-# CONFIG_SYSFS is not set

Hm, I don't see where are you enabling them... So I miss something?

Yes:

config PROC_FS
bool "/proc file system support" if EXPERT default y

config SYSFS
bool "sysfs file system support" if EXPERT default y

Those options are enabled by default. So, when there's nothing in the defconfig file to disable them, they are enabled.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com