ext3: get rid of the duplicate code on ext3_fill_super
PATCH 1/1 ext3: get rid of the duplicate code on ext3_fill_super
From: Zhao Hongjiang <[email protected]>
Clean the duplicate code on ext3_fill_super cause the bellow also have it.
Signed-off-by Zhao Hongjiang <[email protected]>
--- fs/ext3/super.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
fs/ext3/super.c +0 -3
@@ -1661,9 +1661,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)return -ENOMEM ; } sb->s_fs_info = sbi; - sbi->s_mount_opt =0 ; - sbi->s_resuid =make_kuid (&init_user_ns,EXT3_DEF_RESUID ); - sbi->s_resgid =make_kgid (&init_user_ns,EXT3_DEF_RESGID ); sbi->s_sb_block = sb_block; blocksize =sb_min_blocksize (sb,EXT3_MIN_BLOCK_SIZE );
-- 1.7.1
Quoted 6 lines · Zhao Hongjiang
From: Zhao Hongjiang <[email protected]>
Clean the duplicate code on
ext3_fill_supercause the bellow also have it.Signed-off-by Zhao Hongjiang <[email protected]>
Thanks. I've merged the patch to my tree with somewhat updated changelog:
Setting s_mount_opt to 0 is unnecessary because we use kzalloc() for sb allocation. s_resuid and s_resgid are set again few lines below based on values in on disk superblock.
Honza
Quoted 19 lines
--- fs/ext3/super.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)fs/ext3/super.c +0
-4@@ -1661,9 +1661,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)return -ENOMEM ; } sb->s_fs_info = sbi; - sbi->s_mount_opt =0 ; - sbi->s_resuid =make_kuid (&init_user_ns,EXT3_DEF_RESUID ); - sbi->s_resgid =make_kgid (&init_user_ns,EXT3_DEF_RESGID ); sbi->s_sb_block = sb_block; blocksize =sb_min_blocksize (sb,EXT3_MIN_BLOCK_SIZE ); -- 1.7.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR