Skip to contentSkip to conversation

fix display of plugin hook types

PATCH In review Heiko Hund 2 participants 2 messages Oct 29, 2012

lore
Share & tools
lore

Heiko Hund

author
#0 lore raw

PATCH 1/1 fix display of plugin hook types

The OPENVPN_PLUGIN_ROUTE_PREDOWN hook was missing and displayed as "PLUGIN_???" in the log.

OPENVPN_PLUGIN_ENABLE_PF was the only one that displayed the OPENVPN_ prefix.

---
 src/openvpn/plugin.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/openvpn/plugin.c +3 -1
index 944d833..83f79e4 100644
@@ -98,7 +98,9 @@ plugin_type_name (const int type)
     case OPENVPN_PLUGIN_TLS_FINAL:
       return "PLUGIN_TLS_FINAL";
     case OPENVPN_PLUGIN_ENABLE_PF:
-      return "OPENVPN_PLUGIN_ENABLE_PF";
+      return "PLUGIN_ENABLE_PF";
+    case OPENVPN_PLUGIN_ROUTE_PREDOWN:
+      return "PLUGIN_ROUTE_PREDOWN";
     default:
       return "PLUGIN_???";
     }
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 11 lines · Heiko Hund

The OPENVPN_PLUGIN_ROUTE_PREDOWN hook was missing and displayed as "PLUGIN_???" in the log.

OPENVPN_PLUGIN_ENABLE_PF was the only one that displayed the OPENVPN_ prefix.

---
 src/openvpn/plugin.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

ACK. Applied to master and beta/2.3

commit ae303d444c11984b87e0046c4138982d7a41fd8b (master) commit 3b8d116d3d9dbe2fac786311db8b2bec53d88c77 (beta/2.3)

Author: Heiko Hund <[email protected]...>
Date:   Mon Oct 29 14:38:30 2012 +0100
    Fix display of plugin hook types

    Signed-off-by: Heiko Hund <[email protected]...>
    Acked-by: David Sommerseth <[email protected]...>
    Message-Id: [email protected]...
    URL: http://article.gmane.org/gmane.network.openvpn.devel/7111
    Signed-off-by: David Sommerseth <[email protected]...>
    (cherry picked from commit ae303d444c11984b87e0046c4138982d7a41fd8b)

kind regards,

David Sommerseth