Skip to contentSkip to conversation

ARM: highbank: retry wfi on reset request

PATCH New Rob Herring 2 participants 3 messages Oct 26, 2012 – Nov 6, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/calxeda highbank architecture
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 ARM: highbank: retry wfi on reset request

From: Rob Herring <[email protected]>

In some cases, an interrupt can occur and prevent cause failure to enter wfi. This causes reset to hang. Retrying the wfi should be enough to prevent reset from hanging.

Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/mach-highbank/system.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-highbank/system.c +2 -1
index 82c2723..86e37cd 100644
@@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
 		hignbank_set_pwr_soft_reset();
 
 	scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
-	cpu_do_idle();
+	while (1)
+		cpu_do_idle();
 }
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 ARM: highbank: retry wfi on reset request

Quoted 8 lines · Rob Herring

From: Rob Herring <[email protected]>

In some cases, an interrupt can occur and prevent cause failure to enter wfi. This causes reset to hang. Retrying the wfi should be enough to prevent reset from hanging.

Signed-off-by Rob Herring <[email protected]>

---

Arnd, Olof,

Can you please apply this for 3.7?

Rob

Quoted 17 lines
 arch/arm/mach-highbank/system.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-highbank/system.c +2 -1
index 82c2723..86e37cd 100644
@@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
 		hignbank_set_pwr_soft_reset();
 
 	scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
-	cpu_do_idle();
+	while (1)
+		cpu_do_idle();
 }