cosmetic issue with error message 'Invalid Power Resource to register!'
From time to time I get a line like at my Gentoo Linux:
kernel: ACPI: Invalid Power Resource to register!<6>usb 2-1.2: new high-speed USB device number 3 using ehci_hcd
I'm wondering whether there should be newline between both of them or what <6> means.
Signature · 7 lines
MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 acpi: add newline in power.c message
From: Randy Dunlap <[email protected]>
Add newline to printk so that the message is on a line by itself and not merged with something unrelated to it.
--- drivers/acpi/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/power.c +1 -1
@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(return ret; no_power_resource: - printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!"); + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");return -ENODEV ; }EXPORT_SYMBOL_GPL (acpi_power_resource_register_device);
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] acpi: add newline in power.c message
Quoted 16 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Add newline to printk so that the message is on a line by itself and not merged with something unrelated to it.
Signed-off-by Randy Dunlap <[email protected]>Reported-by Toralf Förster <[email protected]>Cc Len Brown <[email protected]>Cc Rafael J. Wysocki <[email protected]>--- drivers/acpi/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/power.c int acpi_power_resource_register_device( · line 476
Quoted 5 lines
drivers/acpi/power.c +1
-1@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(return ret; no_power_resource: - printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!"); + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
It'd be nice if this and the other similar printks in this file included a hint about the context, e.g., the device to which it's related.
Quoted 7 lines
drivers/acpi/power.c +0
-1return -ENODEV ; }EXPORT_SYMBOL_GPL (acpi_power_resource_register_device); --To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki
AppliedRe: [PATCH] acpi: add newline in power.c message
In reply to Randy DunlapQuoted 9 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Add newline to printk so that the message is on a line by itself and not merged with something unrelated to it.
Signed-off-by Randy Dunlap <[email protected]>Reported-by Toralf Förster <[email protected]>Cc Len Brown <[email protected]>Cc Rafael J. Wysocki <[email protected]>
Applied to the linux-next branch of the linux-pm.git tree as v3.8 material.
Thanks,
Rafael
Quoted 16 lines
--- drivers/acpi/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/power.c +1
-1@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(return ret; no_power_resource: - printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!"); + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");return -ENODEV ; }EXPORT_SYMBOL_GPL (acpi_power_resource_register_device);
Signature · 6 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html