grantlee: new package
PATCH 1/1 grantlee: new package
Support for the Grantlee library
Grantlee is a Qt implementation of the Django template system, see here:
http://www.gitorious.org/grantlee/pages/Home
(it's my first patch to buildroot, so please let me know any notes, thx)
--- package/Config.in | 1 + package/grantlee/Config.in | 8 ++++++++ package/grantlee/grantlee.mk | 14 ++++++++++++++ 3 files changed, 23 insertions(+)
create mode 100644 package/grantlee/Config.in
create mode 100644 package/grantlee/grantlee.mk
package/Config.in +1 -0
@@ -139,6 +139,7 @@ source "package/qt/Config.in" if BR2_PACKAGE_QT comment "QT libraries and helper libraries" source "package/qtuio/Config.in" +source "package/grantlee/Config.in" endif source "package/x11r7/Config.in"
package/grantlee/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_GRANTLEE + bool "grantlee" + depends on BR2_PACKAGE_QT + select BR2_PACKAGE_QT_STL + help + Qt implemantation of the Django template framework + + http://www.grantlee.org/apidox
package/grantlee/grantlee.mk new file +14 -0
@@ -0,0 +1,14 @@ +############################################################# +# +# grantlee +# +############################################################# + +GRANTLEE_VERSION = 0.2.0 +GRANTLEE_SITE = http://downloads.grantlee.org/ +GRANTLEE_INSTALL_STAGING = YES +GRANTLEE_INSTALL_TARGET = YES +GRANTLEE_DEPENDENCIES = host-pkg-config qt + +$(eval $(cmake-package)) +
Signature · 1 line
1.7.9.5
PATCH 1/1 grantlee: new package
Quoted 1 line · Zoltan Gyarmati
Support for the Grantlee library
This sentence is redundant.
Quoted 1 line
Grantlee is a Qt implementation of the Django template system, see here: http://www.gitorious.org/grantlee/pages/Home
Word-wrap the commit message at +- 75 characters. But actually, this
part of the commit message is redundant because it's already in the help text.
Quoted 2 lines
(it's my first patch to buildroot, so please let me know any notes, thx)
Doing that :-)
Something like this (a note that shouldn't be part of the final commit message)
should go below your SOB, separated by --- on a line by itself. Then git-am will strip it off while applying the patch.
Quoted 2 lines
Signed-off-by "Zoltan Gyarmati" <[email protected]>
[snip]
package/grantlee/Config.in line 2
Quoted 8 lines
package/grantlee/Config.in new file +2
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_GRANTLEE + bool "grantlee"
Config.in indentation should be one tab.
package/grantlee/Config.in line 3
Quoted 1 line
package/grantlee/Config.in new file +1
-0+ depends on BR2_PACKAGE_QT
This is redundant, because it's already inside an
if BR2_PACKAGE_QT (in package/Config.in).
package/grantlee/Config.in line 4
Quoted 1 line
package/grantlee/Config.in new file +1
-0+ select BR2_PACKAGE_QT_STL
It looks like BR2_PACKAGE_QT_SCRIPT and BR2_PACKAGE_QT_GUI_MODULE
are also required. I didn't continue testing, so maybe even that is not enough.
package/grantlee/Config.in line 8
Quoted 4 lines
package/grantlee/Config.in new file +4
-0+ help + Qt implemantation of the Django template framework + + http://www.grantlee.org/apidox
And the help text indentation: one tab + 2 spaces.
Also I think http://grantlee.org is a more appropriate URL, even
if it just redirects to gitorious.
Quoted 6 lines
package/grantlee/grantlee.mk new file +0
-0
package/grantlee/grantlee.mk line 8
Quoted 8 lines
package/grantlee/grantlee.mk new file +8
-0@@ -0,0 +1,14 @@ +############################################################# +# +# grantlee +# +############################################################# + +GRANTLEE_VERSION = 0.2.0 +GRANTLEE_SITE = http://downloads.grantlee.org/
Trailing / is redundant.
package/grantlee/grantlee.mk line 10
Quoted 2 lines
package/grantlee/grantlee.mk new file +2
-0+GRANTLEE_INSTALL_STAGING = YES +GRANTLEE_INSTALL_TARGET = YES
INSTALL_TARGET defaults to YES, so can be removed.
package/grantlee/grantlee.mk line 11
Quoted 1 line
package/grantlee/grantlee.mk new file +1
-0+GRANTLEE_DEPENDENCIES = host-pkg-config qt
pkgconf just got committed, so should be host-pkgconf. But AFAICS it isn't
using pkg-config for anything.
Also, your mailer messed up the whitespace in your patch. Use
git-send-email, that works well. The man page explains how to use it with gmail.
Regards,
Arnout
Quoted 3 lines
package/grantlee/grantlee.mk new file +3
-0+ +$(eval $(cmake-package)) +
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 grantlee: new package
Hi,
Thx for the detailed comments, i'll resend it. And as i realized in the debian/ubuntu repos the package called libgrantlee,
so maybe it would be better to call it so also in buildroot, as it's more logical name for a library :) What do you think?
Quoted 100 lines · Arnout Vandecappelle
Quoted 1 line · Zoltan Gyarmati
Support for the Grantlee library
This sentence is redundant.
Quoted 2 lines
Grantlee is a Qt implementation of the Django template system, see
here: http://www.gitorious.org/grantlee/pages/HomeWord-wrap the commit message at +- 75 characters. But actually, this
part of the commit message is redundant because it's already in the help text.Quoted 2 lines
(it's my first patch to buildroot, so please let me know any notes, thx)
Doing that :-)
Something like this (a note that shouldn't be part of the final
commit message)
should go below your SOB, separated by --- on a line by itself. Then git-am will strip it off while applying the patch.Quoted 2 lines
Signed-off-by "Zoltan Gyarmati" <[email protected]>[snip]
package/grantlee/Config.in line 2
Quoted 8 lines
package/grantlee/Config.in new file +2
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_GRANTLEE + bool "grantlee"Config.in indentation should be one tab.
package/grantlee/Config.in line 3
Quoted 1 line
package/grantlee/Config.in new file +1
-0+ depends on BR2_PACKAGE_QTThis is redundant, because it's already inside an
ifBR2_PACKAGE_QT(in package/Config.in).package/grantlee/Config.in line 4
Quoted 1 line
package/grantlee/Config.in new file +1
-0+ select BR2_PACKAGE_QT_STLIt looks like
BR2_PACKAGE_QT_SCRIPTandBR2_PACKAGE_QT_GUI_MODULE
are also required. I didn't continue testing, so maybe even that is not enough.package/grantlee/Config.in line 8
Quoted 4 lines
package/grantlee/Config.in new file +4
-0+ help + Qt implemantation of the Django template framework + + http://www.grantlee.org/apidoxAnd the help text indentation: one tab + 2 spaces.
Also I think http://grantlee.org is a more appropriate URL, even
if it just redirects to gitorious.Quoted 6 lines
package/grantlee/grantlee.mk new file +0
-0package/grantlee/grantlee.mk line 8
Quoted 8 lines
package/grantlee/grantlee.mk new file +8
-0@@ -0,0 +1,14 @@ +############################################################# +# +# grantlee +# +############################################################# + +GRANTLEE_VERSION = 0.2.0 +GRANTLEE_SITE = http://downloads.grantlee.org/Trailing / is redundant.
package/grantlee/grantlee.mk line 10
Quoted 2 lines
package/grantlee/grantlee.mk new file +2
-0+GRANTLEE_INSTALL_STAGING = YES +GRANTLEE_INSTALL_TARGET = YES
INSTALL_TARGETdefaults to YES, so can be removed.package/grantlee/grantlee.mk line 11
Quoted 1 line
package/grantlee/grantlee.mk new file +1
-0+GRANTLEE_DEPENDENCIES = host-pkg-config qtpkgconf just got committed, so should be host-pkgconf. But AFAICS it
isn't
using pkg-config for anything.Also, your mailer messed up the whitespace in your patch. Use
git-send-email, that works well. The man page explains how to use it with
gmail.Regards,
ArnoutQuoted 3 lines
package/grantlee/grantlee.mk new file +3
-0+ +$(eval $(cmake-package)) +
PATCH 1/1 grantlee: new package
Quoted 4 lines · Zoltan Gyarmati
Hi,
Thx for the detailed comments, i'll resend it. And as i realized in the debian/ubuntu repos the package called libgrantlee, so maybe it would be better to call it so also in buildroot, as it's more logical name for a library :) What do you think?
In buildroot, we prefer to use the upstream name.
In Debian/Fedora distros, they split packages into a lib- and a bin- package
(and additional -dev and -dbg packages). For grantlee, there is no bin-, so you don't get a plain grantlee package.
In buildroot, we don't split the packages (sometimes there are sub-options to
disable the binaries). Therefore, there is no reason to change the name.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 grantlee: new package
Quoted 14 lines · Arnout Vandecappelle
Quoted 6 lines · Zoltan Gyarmati
Hi,
Thx for the detailed comments, i'll resend it. And as i realized in the debian/ubuntu repos the package called libgrantlee, so maybe it would be better to call it so also in buildroot, as it's more logical name for a library :) What do you think?
In buildroot, we prefer to use the upstream name.
In Debian/Fedora distros, they split packages into a lib- and a bin- package (and additional -dev and -dbg packages). For grantlee, there is no bin-, so you don't get a plain grantlee package.
Quoted 6 lines
In buildroot, we don't split the packages (sometimes there are sub-options to disable the binaries). Therefore, there is no reason to change the name.
Regards, Arnout
Hi,
ok, i see. Is there any policy/standards document or wikipage somewhere which summarizes this kind of practices?
I couldn't find it so far. What i found is mostly technical kind of infos. (which is extremly useful of course :)
best regards
Zoltan Gyarmati