patman: Issue empty change logs for unchanged patches

PATCH New Simon Glass 3 participants 3 messages Oct 30, 2012 – Nov 7, 2012

Share & tools

Simon Glass

author

2012-10-30 16:15 UTC #0 lore raw

PATCH 1/1 patman: Issue empty change logs for unchanged patches

Often a particular patch may change only for some versions of a series. For versions where there is no change, issue a change log indicating that (for example 'Changes in v4: None').

For such lines, don't add a blank line afterwards, to conserve space. Use list.insert() instead of list = [item] + list.

Signed-off-by Simon Glass <[email protected]>

---
 tools/patman/series.py |   21 +++++++++++++--------
 1 files changed, 13 insertions(+), 8 deletions(-)

tools/patman/series.py +13 -8

index a283a2d..d2971f4 100644
@@ -145,10 +145,11 @@ class Series(dict):
         Return:
             The change log as a list of strings, one per line
 
-            Changes in v2:
+            Changes in v4:
             - Jog the dial back closer to the widget
 
-            Changes in v1:
+            Changes in v3: None
+            Changes in v2:
             - Fix the widget
             - Jog the dial

@@ -162,12 +163,16 @@ class Series(dict):
                 if commit and this_commit != commit:
                     continue
                 out.append(text)
-            if out:
-                out = ['Changes in v%d:' % change] + out
-                if need_blank:
-                    out = [''] + out
-                final += out
-                need_blank = True
+            line = 'Changes in v%d:' % change
+            have_changes = len(out) > 0
+            if have_changes:
+                out.insert(0, line)
+            else:
+                out = [line + ' None']
+            if need_blank:
+                out.insert(0, '')
+            final += out
+            need_blank = have_changes
         if self.changes:
             final.append('')
         return final

Signature · 1 line

1.7.7.3

Stefan Roese

2012-10-31 16:12 UTC #1 lore raw

PATCH 1/1 patman: Issue empty change logs for unchanged patches

Quoted 8 lines · Simon Glass

Often a particular patch may change only for some versions of a series. For versions where there is no change, issue a change log indicating that (for example 'Changes in v4: None').
For such lines, don't add a blank line afterwards, to conserve space. Use list.insert() instead of list = [item] + list.
Signed-off-by Simon Glass <[email protected]>

Nice! That was quick! Thirsty? ;)

Tested-by Stefan Roese <[email protected]>

Thanks,
Stefan

Anatolij Gustschin

Applied

2012-11-07 23:20 UTC #2 lore raw

PATCH 1/1 patman: Issue empty change logs for unchanged patches

In reply to Simon Glass

Hi,

Quoted 11 lines · On Tue, 30 Oct 2012 09:15:16 -0700 Simon Glass <[email protected]> wrote:

Often a particular patch may change only for some versions of a series. For versions where there is no change, issue a change log indicating that (for example 'Changes in v4: None').
For such lines, don't add a blank line afterwards, to conserve space. Use list.insert() instead of list = [item] + list.
Signed-off-by Simon Glass <[email protected]>
---
 tools/patman/series.py |   21 +++++++++++++--------
 1 files changed, 13 insertions(+), 8 deletions(-)

Applied to staging/agust at denx.de. Thanks!

Anatolij