net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

PATCH New Chen Gang 3 participants 7 messages Nov 2, 2012 – Nov 5, 2012

Subsystems (3)

Networking Network drivers IPv4/IPv6

lore

Share & tools

lore

Chen Gang

author

2012-11-02 08:54 UTC #0 lore raw

PATCH 1/1 net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

Hello Eric Dumazet:

1) This time (the first time):
A) I have done according to what you have suggested.
i) git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
ii) format with git format-patch -s --summary --stat
iii) cc to [email protected] (not to [email protected])
B) please check the 'Main Contents' (below of this mail).
C) thank you for your original information again, they are truly useful for me.

2) Next time (if also for net/ipv6):
A) I will send mail according to MAINTAINERS (which also you suggested)

      M:      "David S. Miller" <[email protected]>
      M:      Alexey Kuznetsov <[email protected]>
      M:      James Morris <[email protected]>
      M:      Hideaki YOSHIFUJI <[email protected]>
      M:      Patrick McHardy <[email protected]>
      L:      [email protected]
      T:      git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git

B) Only have 'Main Content' in next time.

Main Contents:
-----------------------------------------------------------------------------------
From: Chen Gang <[email protected]>
Date: Fri, 2 Nov 2012 16:02:11 +0800
Subject: [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.

additional information:

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.

%.8s truly limit the original string output length (precision)

Signed-off-by Chen Gang <[email protected]>

---
 net/ipv6/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/ipv6/route.c +1 -1

index c42650c..b60bc52 100644
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
        } else {
                seq_puts(m, "00000000000000000000000000000000");
        }
-       seq_printf(m, " %08x %08x %08x %08x %8s\n",
+       seq_printf(m, " %08x %08x %08x %08x %s\n",
                   rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
                   rt->dst.__use, rt->rt6i_flags,
                   rt->dst.dev ? rt->dst.dev->name : "");

Signature · 9 lines

1.7.9.5




-- 
Chen Gang

Asianux Corporation

Chen Gang

author

2012-11-02 09:27 UTC #1 lore raw

PATCH 1/1 net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

Hello Eric Dumazet:

2) Next time (if also for net/ipv6):
A) I will send mail according to MAINTAINERS (which also you suggested)

      M:      "David S. Miller" <[email protected]>
      M:      Alexey Kuznetsov <[email protected]>
      M:      James Morris <[email protected]>
      M:      Hideaki YOSHIFUJI <[email protected]>
      M:      Patrick McHardy <[email protected]>
      L:      [email protected]
      T:      git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git

B) Only have 'Main Content' in next time.

the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.

additional information:

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.

%.8s truly limit the original string output length (precision)

Signed-off-by Chen Gang <[email protected]>

---
 net/ipv6/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/ipv6/route.c +1 -1

index c42650c..b60bc52 100644
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
        } else {
                seq_puts(m, "00000000000000000000000000000000");
        }
-       seq_printf(m, " %08x %08x %08x %08x %8s\n",
+       seq_printf(m, " %08x %08x %08x %08x %s\n",
                   rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
                   rt->dst.__use, rt->rt6i_flags,
                   rt->dst.dev ? rt->dst.dev->name : "");

Signature · 9 lines

1.7.9.5




-- 
Chen Gang

Asianux Corporation

Chen Gang

author

2012-11-02 12:17 UTC #2 lore raw

PATCH 1/1 net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

In reply to Chen Gang

the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.

additional information:

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.

%.8s truly limit the original string output length (precision)

Signed-off-by Chen Gang <[email protected]>

---
 net/ipv6/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/ipv6/route.c +1 -1

index c42650c..b60bc52 100644
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
        } else {
                seq_puts(m, "00000000000000000000000000000000");
        }
-       seq_printf(m, " %08x %08x %08x %08x %8s\n",
+       seq_printf(m, " %08x %08x %08x %08x %s\n",
                   rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
                   rt->dst.__use, rt->rt6i_flags,
                   rt->dst.dev ? rt->dst.dev->name : "");

Signature · 9 lines

1.7.9.5




-- 
Chen Gang

Asianux Corporation

Shan Wei

2012-11-02 15:40 UTC #3 lore raw

Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

Chen Gang said, at 2012/11/2 20:18:

Quoted 7 lines

the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.
additional information:

Quoted 8 lines

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by Chen Gang <[email protected]>

1. not to send same patch triple times.
2. config your email client,because tab is changed to space. you can read Documentation/email-clients.txt.

Chen Gang

author

2012-11-05 03:01 UTC #4 lore raw

Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

Quoted 2 lines

1. not to send same patch triple times.

thanks, I shall notice, next time.
(I shall 'believe' another members).

Quoted 2 lines

2. config your email client,because tab is changed to space. you can read Documentation/email-clients.txt.

1) thanks. I shall notice, next time.
2) now, I get gvim as extention editor for thounderbird
3) the patch is generated by git format-patch -s --summary --stat it use "' '\t" as head, I do not touch it, maybe it is correct.

welcome any members to giving additional suggestions and completions.

thanks

the modified contents are below,
-----------------------------------------------------------------------------------

the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.

additional information:

%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name.

%.8s truly limit the original string output length (precision)

Signed-off-by Chen Gang <[email protected]>

---
 net/ipv6/route.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/ipv6/route.c +1 -1

index c42650c..b60bc52 100644
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
 	} else {
 		seq_puts(m, "00000000000000000000000000000000");
 	}
-	seq_printf(m, " %08x %08x %08x %08x %8s\n",
+	seq_printf(m, " %08x %08x %08x %08x %s\n",
 		   rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
 		   rt->dst.__use, rt->rt6i_flags,
 		   rt->dst.dev ? rt->dst.dev->name : "");

Signature · 1 line

1.7.9.5

David Miller

maintainer

2012-11-05 05:51 UTC #5 lore raw

Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

From: Chen Gang <[email protected]>
Date: Mon, 05 Nov 2012 11:02:48 +0800

Quoted 14 lines

Quoted 2 lines
1. not to send same patch triple times.
thanks, I shall notice, next time.
(I shall 'believe' another members).
Quoted 2 lines
2. config your email client,because tab is changed to space. you can read Documentation/email-clients.txt.
1) thanks. I shall notice, next time.
2) now, I get gvim as extention editor for thounderbird
3) the patch is generated by git format-patch -s --summary --stat it use "' '\t" as head, I do not touch it, maybe it is correct.

Quoted 5 lines

welcome any members to giving additional suggestions and completions.
thanks
the modified contents are below,

Post new versions of a patch as fresh postings, not as replies to other emails.

Chen Gang

author

2012-11-05 06:01 UTC #6 lore raw

Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route

Quoted 5 lines · David Miller

Post new versions of a patch as fresh postings, not as replies to other emails.

thanks, I shall notice, next time.
if truly need sending it again (5th time), please tell me, thanks. (since, it has been posted "4 times", which has almost been 'spam')

Signature · 3 lines

Chen Gang

Asianux Corporation