net: batman-adv: use per_cpu_add helper
Subsystems (3)
PATCH v2 9/9 net: batman-adv: use per_cpu_add helper
From: Shan Wei <[email protected]>
Quoted 8 lines · As Christoph Lameter
In addition, following usage of
per_cpu_ptrcan be replaced bythis_cpu_read.cpu=get_cpu()
....*per_cpu_ptr(p,cpu)
....
....put_cpu()
Right.
--- net/batman-adv/main.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
net/batman-adv/main.h +1 -3
@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,static inline void batadv_add_counter (struct batadv_priv *bat_priv,size_t idx,size_t count) { -int cpu =get_cpu (); -per_cpu_ptr (bat_priv->bat_counters, cpu)[idx] += count; -put_cpu (); +this_cpu_add (bat_priv->bat_counters[idx], count); }#define batadv_inc_counter (b, i) batadv_add_counter(b, i, 1)
Signature · 1 line
1.7.1
net/batman-adv/main.h static inline bool batadv_has_timed_out(unsigned long timestamp, · line 267
Quoted 13 lines · Shan Wei
net/batman-adv/main.h +1
-3@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,static inline void batadv_add_counter (struct batadv_priv *bat_priv,size_t idx,size_t count) { -int cpu =get_cpu (); -per_cpu_ptr (bat_priv->bat_counters, cpu)[idx] += count; -put_cpu (); +this_cpu_add (bat_priv->bat_counters[idx], count); }
Sven Eckelmann
maintainerQuoted 13 lines · On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
From: Shan Wei <[email protected]>
Quoted 9 lines · As Christoph Lameter
In addition, following usage of
per_cpu_ptrcan be replaced bythis_cpu_read.cpu=get_cpu()
....*per_cpu_ptr(p,cpu)
....
....put_cpu()
Quoted 4 lines
Right.
Signed-off-by Shan Wei <[email protected]>---
Is this really supposed to be the commit message?
Kind regards,
Sven
Sven Eckelmann said, at 2012/11/3 1:55:
Quoted 14 lines · On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
Quoted 13 lines
From: Shan Wei <[email protected]>
Quoted 9 lines · As Christoph Lameter
In addition, following usage of
per_cpu_ptrcan be replaced bythis_cpu_read.cpu=get_cpu()
....*per_cpu_ptr(p,cpu)
....
....put_cpu()
Quoted 6 lines
Quoted 4 lines
Right.
Signed-off-by Shan Wei <[email protected]>---
Is this really supposed to be the commit message?
Maybe it's ok when Linus said this. :-)
Christoph is the maintainer of per-cpu.
So........
PER-CPU MEMORY ALLOCATOR
M: Tejun Heo <[email protected]> M: Christoph Lameter <[email protected]> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git S: Maintained F: include/linux/percpu*.h F: mm/percpu*.c F: arch/*/include/asm/percpu.h
Quoted 4 lines
Kind regards,
Sven
Sven Eckelmann
maintainerQuoted 20 lines · On Saturday 03 November 2012 12:58:45 Shan Wei wrote:
Sven Eckelmann said, at 2012/11/3 1:55:
Quoted 19 lines · On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
Quoted 17 lines
From: Shan Wei <[email protected]>
Quoted 9 lines · As Christoph Lameter
In addition, following usage of
per_cpu_ptrcan be replaced bythis_cpu_read.cpu=get_cpu()
....*per_cpu_ptr(p,cpu)
....
....put_cpu()Right.
Signed-off-by Shan Wei <[email protected]>---
Quoted 6 lines
Quoted 1 line
Is this really supposed to be the commit message?
Maybe it's ok when Linus said this. :-)
Christoph is the maintainer of per-cpu.
So........
Hm? This wasn't my question, but ok...
Kind regards,
Sven
Quoted 5 lines · Shan Wei
Quoted 1 line
Is this really supposed to be the commit message?
Maybe it's ok when Linus said this. :-)
Christoph is the maintainer of per-cpu.
Well please make the changelog nice and understandable.