Skip to contentSkip to conversation

sh: fix trigger_address_error()

PATCH New Shimoda 2 participants 2 messages Nov 5, 2012 – Nov 12, 2012 SuperH

lore
Share & tools
lore

Shimoda

#0 lore raw

PATCH 1/1 sh: fix trigger_address_error()

The function should set BL bit, but it should not clear other flags. So, the patch uses set_bl_bit() instead of a local asm code.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 arch/sh/include/asm/system.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sh/include/asm/system.h +1 -1
index 56fd77a..24b5ce8 100644
@@ -274,8 +274,8 @@ void enable_hlt(void);
 
 static inline void trigger_address_error(void)
 {
+	set_bl_bit();
 	__asm__ __volatile__ (
-		"ldc %0, sr\n\t"
 		"mov.l @%1, %0"
 		:
 		: "r" (0x10000000), "r" (0x80000001)
Signature · 1 line
1.7.1
Applied
#1 lore raw

PATCH 1/1 sh: fix trigger_address_error()

Applied, thanks.

Best regards,
Nobuhiro

Quoted 24 lines · Yoshihiro

The function should set BL bit, but it should not clear other flags. So, the patch uses set_bl_bit() instead of a local asm code.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 arch/sh/include/asm/system.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sh/include/asm/system.h +1 -2
index 56fd77a..24b5ce8 100644
@@ -274,8 +274,8 @@ void enable_hlt(void);
 
 static inline void trigger_address_error(void)
 {
+       set_bl_bit();
        __asm__ __volatile__ (
-               "ldc %0, sr\n\t"
                "mov.l @%1, %0"
                :
                : "r" (0x10000000), "r" (0x80000001)
--

1.7.1

Signature · 3 lines
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6