Skip to contentSkip to conversation

tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

PATCH Superseded Simon Glass 3 participants 5 messages Nov 5, 2012 – Nov 6, 2012

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Simon Glass

author
#0 lore raw

PATCH 1/2 tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

Now that we are using the new CONFIG_SYS_NAND_SELF_INIT setup, we don't need CONFIG_SYS_NAND_BASE. Punt it.

Signed-off-by Simon Glass <[email protected]>
---
 include/configs/seaboard.h |    3 ---
 include/configs/tec.h      |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)
include/configs/seaboard.h +0 -3
index 7680c77..3fca8d9 100644
@@ -124,7 +124,4 @@
 
 /* Max number of NAND devices */
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
-
-/* Somewhat oddly, the NAND base address must be a config option */
-#define CONFIG_SYS_NAND_BASE	NV_PA_NAND_BASE
 #endif /* __CONFIG_H */
include/configs/tec.h +0 -1
index 140d2e6..200cf66 100644
@@ -54,7 +54,6 @@
 #define CONFIG_CMD_NAND
 #define CONFIG_TEGRA_NAND
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
-#define CONFIG_SYS_NAND_BASE		NV_PA_NAND_BASE
 
 /* Environment in NAND, aligned to start of last sector */
 #define CONFIG_ENV_IS_IN_NAND
Signature · 1 line
1.7.7.3
author
#1 lore raw

PATCH 2/2 tegra: config: seaboard: Move tegra-common-post to correct place

The NAND defines ended up before this include file, but should be after it, so it doesn't become a post-pre-NAND.

Signed-off-by Simon Glass <[email protected]>
---
 include/configs/seaboard.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
include/configs/seaboard.h +3 -2
index 3fca8d9..32816b1 100644
@@ -116,12 +116,13 @@
 #define CONFIG_SYS_WHITE_ON_BLACK
 #define CONFIG_CONSOLE_SCROLL_LINES	10
 
-#include "tegra-common-post.h"
-
 /* NAND support */
 #define CONFIG_CMD_NAND
 #define CONFIG_TEGRA_NAND
 
 /* Max number of NAND devices */
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
+
+#include "tegra-common-post.h"
+
 #endif /* __CONFIG_H */
Signature · 1 line
1.7.7.3
#2 lore raw

PATCH 2/2 tegra: config: seaboard: Move tegra-common-post to correct place

Quoted 2 lines · Simon Glass

The NAND defines ended up before this include file, but should be after it, so it doesn't become a post-pre-NAND.

The series,

Acked-by Stephen Warren <[email protected]>
#3 lore raw

PATCH 1/2 tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

In reply to Simon Glass

Simon,

Quoted 7 lines

-----Original Message-----
From: Simon Glass [mailto:sjg at chromium.org]
Sent: Monday, November 05, 2012 4:21 PM
To: U-Boot Mailing List
Cc: Tom Warren; Stephen Warren; Simon Glass; Stephen Warren
Subject: [PATCH 1/2] tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

Quoted 8 lines

Now that we are using the new CONFIG_SYS_NAND_SELF_INIT setup, we don't need CONFIG_SYS_NAND_BASE. Punt it.

Signed-off-by Simon Glass <[email protected]>
---
 include/configs/seaboard.h |    3 ---
 include/configs/tec.h      |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

Harmony.h uses it, too.

Tom

Quoted 27 lines
include/configs/seaboard.h index renamed from include/configs/seaboard.h +0 -0

7680c77..3fca8d9 100644

include/configs/seaboard.h +0 -3
@@ -124,7 +124,4 @@
 
 /* Max number of NAND devices */
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
-
-/* Somewhat oddly, the NAND base address must be a config option */
-#define CONFIG_SYS_NAND_BASE	NV_PA_NAND_BASE
 #endif /* __CONFIG_H */
include/configs/tec.h index renamed from include/configs/tec.h +0 -0

140d2e6..200cf66 100644

include/configs/tec.h +0 -1
@@ -54,7 +54,6 @@
 #define CONFIG_CMD_NAND
 #define CONFIG_TEGRA_NAND
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
-#define CONFIG_SYS_NAND_BASE		NV_PA_NAND_BASE
 
 /* Environment in NAND, aligned to start of last sector */  #define

CONFIG_ENV_IS_IN_NAND
--
1.7.7.3

Signature · 1 line
nvpublic
author
#4 lore raw

PATCH 1/2 tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

Hi Tom,

Quoted 12 lines · Tom Warren

Simon,

Quoted 10 lines

-----Original Message-----
From: Simon Glass [mailto:sjg at chromium.org]
Sent: Monday, November 05, 2012 4:21 PM
To: U-Boot Mailing List
Cc: Tom Warren; Stephen Warren; Simon Glass; Stephen Warren
Subject: [PATCH 1/2] tegra: Remove unnecessary CONFIG_SYS_NAND_BASE

Now that we are using the new CONFIG_SYS_NAND_SELF_INIT setup, we don't need CONFIG_SYS_NAND_BASE. Punt it.

Quoted 7 lines
Quoted 5 lines
Signed-off-by Simon Glass <[email protected]>
---
 include/configs/seaboard.h |    3 ---
 include/configs/tec.h      |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

Harmony.h uses it, too.

Oh right. The two harmonies on my windowsill are staring at me. I will update it.

Regards,
Simon

Quoted 31 lines

Tom

Quoted 24 lines
include/configs/seaboard.h index renamed from include/configs/seaboard.h +0 -0

7680c77..3fca8d9 100644

include/configs/seaboard.h +0 -3
@@ -124,7 +124,4 @@
 
 /* Max number of NAND devices */
 #define CONFIG_SYS_MAX_NAND_DEVICE   1
-
-/* Somewhat oddly, the NAND base address must be a config option */
-#define CONFIG_SYS_NAND_BASE NV_PA_NAND_BASE
 #endif /* __CONFIG_H */
include/configs/tec.h index renamed from include/configs/tec.h +0 -0

140d2e6..200cf66 100644

include/configs/tec.h +0 -1
@@ -54,7 +54,6 @@
 #define CONFIG_CMD_NAND
 #define CONFIG_TEGRA_NAND
 #define CONFIG_SYS_MAX_NAND_DEVICE   1
-#define CONFIG_SYS_NAND_BASE         NV_PA_NAND_BASE
 
 /* Environment in NAND, aligned to start of last sector */  #define
Quoted 3 lines

CONFIG_ENV_IS_IN_NAND
--
1.7.7.3

--
nvpublic