net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
Subsystems (3)
PATCH 1/1 net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more.
--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/addrconf.c +0 -0
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v) {
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr, ifp->idev->dev->ifindex, ifp->prefix_len,
Signature · 1 line
1.7.9.5
Quoted 5 lines · Chen Gang
the length of
ifp->idev->dev->nameis 16 (IFNAMSIZ)
inseq_printf, it is not suitable to use %8s forrt->dst.dev->name. so change it to %s, since each line has not been solid any more.
1) sorry, the comments is incorrect
need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line. I will send it again.
2) By the way, the three patches "* %8s to %s *" are almost the same If need merge them into one patch, please tell me, I shall do.
thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
Chen Gang said, at 2012/11/6 9:11:
Quoted 3 lines
1) sorry, the comments is incorrect
need useifp->idev->dev->nameinstead ofrt->dst.dev->namein 2nd line. I will send it again.
New patch, you should tag new version in [PATCH] to distinguish them. i.e. [PATCH V4]
Quoted 3 lines
2) By the way, the three patches "* %8s to %s *" are almost the same If need merge them into one patch, please tell me, I shall do.
trivial patches, send them in one patch for net/ subsystem.
Quoted 3 lines
thanks.
Quoted 4 lines · Shan Wei
New patch, you should tag new version in [PATCH] to distinguish them. i.e. [PATCH V4]
thanks, I shall do it next time.
Quoted 3 lines
trivial patches, send them in one patch for
net/subsystem.
1) thanks, I shall do it next time.
2) if necessary
A) need send one patch for the 3 patches, this time,
B) please tell me clearly,
C) I shall do,
3) By the way:
A) for finding bugs, I truly find them one by one;
B) When I find one and send it, not know also have another one.
C) and now
i) I will continue to search the 'same' issue,
ii) if I am 'lucky' enough,
iii) maybe also can find another (but maybe not net/ subsystem)
welcome any members to giving suggestions and completions.
thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
Quoted 3 lines · Shan Wei
trivial patches, send them in one patch for
net/subsystem.
1) Lucky !
A) this time, I truly find another one for "* %8s to %s".
B) in arch/x86/kernel/process_64.c (task->comm, TASK_COMM_LEN is 16).
C) It seems that it is not suitable to send it to net subsystem.
2) Next:
A) I shall send it to relative members according to MAINTAINERS.
3) Suggestions:
welcome any members to giving additional suggestions and completions.
thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
PATCH 1/1 net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
In reply to Chen Gang the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name. so change it to %s, since each line has not been solid any more.
--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/addrconf.c +0 -0
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v) {
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr, ifp->idev->dev->ifindex, ifp->prefix_len,
Signature · 1 line
1.7.9.5
Quoted 23 lines · Chen Gang
the length of
ifp->idev->dev->nameis 16 (IFNAMSIZ)
inseq_printf, it is not suitable to use %8s forifp->idev->dev->name. so change it to %s, since each line has not been solid any more.Signed-off-by Chen Gang <[email protected]>--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/ipv6/addrconf.c +1
-1@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq, void *v)static int if6_seq_show (struct seq_file *seq,void *v) {struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v; - seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n", + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n", &ifp->addr, ifp->idev->dev->ifindex,
Quoted 1 line
ifp->prefix_len,
This is a change in if6_seq_show(), not if6_seq_stop() as mentioned in patch title.
Quoted 5 lines · Eric Dumazet
Quoted 5 lines
(quoted diff) +0
-0@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq, void *v) static int if6_seq_show(struct seq_file *seq, void *v) { struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
Quoted 9 lines
Quoted 5 lines
(quoted diff) +1
-1- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n", + seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n", &ifp->addr, ifp->idev->dev->ifindex,
ifp->prefix_len,This is a change in
if6_seq_show(), notif6_seq_stop()as mentioned in patch title.
sorry again,
I will send it again (although it will almost be spam).
Signature · 3 lines
Chen Gang Asianux Corporation
PATCH 1/1 net: ipv6: change %8s to %s for seq_printf of if6_seq_show
In reply to Chen Gang the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for ifp->idev->dev->name. so change it to %s, since each line has not been solid any more.
--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/addrconf.c +0 -0
@@ -3281,7 +3281,7 @@ static void if6_seq_stop(struct seq_file *seq,
void *v)
static int if6_seq_show(struct seq_file *seq, void *v) {
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %s\n",
&ifp->addr, ifp->idev->dev->ifindex, ifp->prefix_len,
Signature · 1 line
1.7.9.5