Skip to contentSkip to conversation

add new package fxload

PATCH New Jeremy Rosen 3 participants 5 messages Nov 5, 2012 – Nov 7, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1781554.153.1352137532474.JavaMail.rosen@pcrosen

#1 lore raw

PATCH 1/1 add new package fxload

Hello everybody

I recently had to add a small utility called fxload to buildroot

fxload is provided by the linux-hotplug project and is used to upload firmware into usb device it is generally used as a helper function by udev.

This is my first patch to buildroot, so feel free to tell me if I didn't follow the proper protocol, I will gladly correct and resubmit

Regards
J?r?my Rosen

fight key loggers : write some perl using vim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-new-package-fxload.patch
Type: text/x-patch
Size: 2207 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121105/ea1fa413/attachment-0001.bin>

#2 lore raw

PATCH 1/1 add new package fxload

Quoted 8 lines · Jeremy Rosen

Hello everybody

I recently had to add a small utility called fxload to buildroot

fxload is provided by the linux-hotplug project and is used to upload firmware into usb device it is generally used as a helper function by udev.

This is my first patch to buildroot, so feel free to tell me if I didn't follow the proper protocol, I will gladly correct and resubmit

Here goes...

First of all, we prefer the patches to be sent in-line rather than as
attachment. That makes it easier to review by just replying to the mail. git send-email is the easiest way to contribute.

Also I'll warn you: it may take a while (months) before your patch is
accepted even if you make all necessary correction, and we may even forget to include it in the end. That's not because we're evil :-) but because our contribution process is still sub-optimal. Buildroot has grown significantly in number of contributions over the last two years, and our maintainer (Peter Korsgaard) is just saturated. We're still experimenting with ways to improve the process.

Quoted 10 lines

Regards
J?r?my Rosen

fight key loggers : write some perl using vim

Quoted 7 lines

0001-add-new-package-fxload.patch

From a1d3bdcf48851dedeca9597816135f4c1589e37a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Rosen?=<[email protected]>
Date: Fri, 2 Nov 2012 11:43:42 +0100
Subject: [PATCH] add new package fxload

Add a Signed-off-by line for yourself. This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details.

BTW, if you want to add additional comments that aren't supposed to
go in the git log message (e.g. "this is my first patch, please give feedback", add it below the Signed-off-by line, separated by ---. Then git-am will remove that part automatically. If you send an updated patch, it's nice if you can write in this comment section what changed compared to the first one. So typically you'll see:

Signed-off-by ...

---
v2: Incorporated comments from Arnout, except for the foo because blah.

Quoted 27 lines
---
  package/Config.in        |    1 +
  package/fxload/Config.in |    9 +++++++++
  package/fxload/fxload.mk |   20 ++++++++++++++++++++
  3 files changed, 30 insertions(+)

create mode 100644 package/fxload/Config.in
create mode 100644 package/fxload/fxload.mk

package/Config.in +1 -0
index 1df099b..f72a34b 100644
@@ -211,6 +211,7 @@ source "package/flashrom/Config.in"
  source "package/fconfig/Config.in"
  source "package/fis/Config.in"
  source "package/fmtools/Config.in"
+source "package/fxload/Config.in"
  source "package/gadgetfs-test/Config.in"
  source "package/gdisk/Config.in"
  source "package/gpsd/Config.in"
package/fxload/Config.in new file +0 -0
new file mode 100644
index 0000000..6fc28a7

package/fxload/Config.in line 3

Quoted 3 lines
package/fxload/Config.in new file +3 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_FXLOAD
+        bool "fxload"
+        help

This should be indented with a single tab.

package/fxload/Config.in line 9

Quoted 6 lines
package/fxload/Config.in new file +6 -0
+	  This program is conveniently able to download firmware into FX, FX2,
+	  and FX2LP EZ-USB devices, as well as the original AnchorChips EZ-USB.
+	  It is intended to be invoked by hotplug scripts when the unprogrammed
+	  device appears on the bus.
+
+http://sourceforge.net/projects/linux-hotplug/

The URL should be indented like the rest of the help text: 1 tab + 2 spaces.

package/fxload/fxload.mk line 1

Quoted 7 lines
package/fxload/fxload.mk new file +1 -0
new file mode 100644
index 0000000..a9c0249
@@ -0,0 +1,20 @@
+

That empty line shouldn't be there.

package/fxload/fxload.mk line 8

Quoted 7 lines
package/fxload/fxload.mk new file +7 -0
+#############################################################
+#
+# fxload
+#
+#############################################################
+FXLOAD_VERSION = 2008_10_13
+FXLOAD_SOURCE = fxload-$(FXLOAD_VERSION).tar.gz

Since that is the default, we don't write that line.

package/fxload/fxload.mk line 9

Quoted 1 line
package/fxload/fxload.mk new file +1 -0
+FXLOAD_SITE =http://sourceforge.net/projects/linux-hotplug/files/fxload/$(FXLOAD_VERSION)

sf.net URLs are normally
http://downloads.sourceforge.net/project/linux-hotplug/fxload/$(FXLOAD_VERSION)

Maybe yours works as well, but it's nice to have the same pattern everywhere.

package/fxload/fxload.mk line 10

Quoted 1 line
package/fxload/fxload.mk new file +1 -0
+FXLOAD_LICENSE = GPLV2+

It's GPLv2+ (small v).

Also set FXLOAD_LICENSE_FILE = COPYING

package/fxload/fxload.mk line 13

Quoted 3 lines
package/fxload/fxload.mk new file +3 -0
+
+define FXLOAD_BUILD_CMDS
+    $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

For new packages, we try to consistently use

$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all

but that doesn't always work... If it doesn't, your pattern is OK.

package/fxload/fxload.mk line 17

Quoted 4 lines
package/fxload/fxload.mk new file +4 -0
+endef
+
+define FXLOAD_INSTALL_TARGET_CMDS
+    $(MAKE) prefix=$(TARGET_DIR)  -C $(@D) install

We try to call make in exactly the same way in the install commands,
so that if for whatever reason something is still compiled there, it will be compiled correctly.

Overall, it looks very good, though. Congratulations!

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 add new package fxload

Quoted 9 lines

Here goes...

First of all, we prefer the patches to be sent in-line rather than as
attachment. That makes it easier to review by just replying to the mail.
git send-email is the easiest way to contribute.

ok, i'll do take two of the patch using git-send-email, but I'm struggling a bit with the smtp server here at work. I'll try to get it to work...

Quoted 12 lines

Also I'll warn you: it may take a while (months) before your patch is
accepted even if you make all necessary correction, and we may even forget
to include it in the end. That's not because we're evil :-) but because
our contribution process is still sub-optimal. Buildroot has grown significantly in number of contributions over the last two years, and our maintainer (Peter Korsgaard) is just saturated. We're still experimenting
with ways to improve the process.

Fair enough, i'm a maintainer for other FOSS projects, so I know how that sort of problem go...

is Peter the only one comitting ? couldn't someone help with simple patches (like updating version of existing packages)

Quoted 8 lines

Add a Signed-off-by line for yourself. This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more
details.

ok, will do .

BTW, your link is dead, a minute of googling and I found

http://elinux.org/Developer_Certificate_Of_Origin
and
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches

which might be the same thing or close enough to point people to the next time my noob question is asked

Quoted 9 lines

BTW, if you want to add additional comments that aren't supposed to
go in the git log message (e.g. "this is my first patch, please give feedback", add it below the Signed-off-by line, separated by ---. Then git-am will remove that part automatically. If you send an updated patch, it's nice if you can write in this comment section what
changed compared to the first one. So typically you'll see:

Quoted 5 lines
Signed-off-by ...

---
v2: Incorporated comments from Arnout, except for the foo because blah.

I am a bit confused how the text of the message I give to git-send-email mix up with the commit message,

should I just put my personal text after the --- line directly in the commit message (before git-send-email) ?

[snip : comments on the patch itself]

ok, i will do all that for V2

Quoted 3 lines

Overall, it looks very good, though. Congratulations!

thanks, V2 will be even better :D

#4 lore raw

PATCH 1/1 add new package fxload

Quoted 13 lines · Jeremy Rosen
Quoted 12 lines

Also I'll warn you: it may take a while (months) before your patch is
accepted even if you make all necessary correction, and we may even forget
to include it in the end. That's not because we're evil :-) but because
our contribution process is still sub-optimal. Buildroot has grown significantly in number of contributions over the last two years, and our maintainer (Peter Korsgaard) is just saturated. We're still experimenting
with ways to improve the process.

Quoted 3 lines

Fair enough, i'm a maintainer for other FOSS projects, so I know how that sort of problem go...

is Peter the only one comitting ? couldn't someone help with simple patches (like updating version of existing packages)

Note it was decided at the recent Developer Days meeting that patches would be accepted more aggressively. Presumably this means the chances of patches that have been appropriately cleaned up to meet the buildroot guidelines are less likely to be accidentally dropped.

Alex

#5 lore raw

PATCH 1/1 add new package fxload

In reply to Jeremy Rosen
Quoted 7 lines · Jeremy Rosen
Quoted 7 lines

Add a Signed-off-by line for yourself. This is a short way for you

Quoted 6 lines

to
assert that you are entitled to contribute the patch under buildroot's
GPL license. Seehttp://kerneltrap.org/files/Jeremy/DCO.txt for more
details.

Quoted 5 lines

ok, will do .

BTW, your link is dead, a minute of googling and I found

http://elinux.org/Developer_Certificate_Of_Origin

Thanks! I've updated my template with that link.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F