Skip to contentSkip to conversation

gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

PATCH New Alexander Khryukin 3 participants 5 messages Nov 9, 2012 – Nov 10, 2012

lore
Share & tools
lore

Alexander Khryukin

author
#0 lore raw

PATCH 1/1 gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

Signed-off-by Alexander Khryukin <[email protected]>
---
 package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
package/gnutls/gnutls-2.12.20-glibc2.16.patch new file +26 -0
new file mode 100644
index 0000000..6b7f545
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h
+@@ -714,8 +714,10 @@
+ /* It is very rare that the developer ever has full control of stdin,
+    so any use of gets warrants an unconditional warning.  Assume it is
+    always declared, since it is required by C89.  */
++#ifdef HAVE_RAW_DECL_GETS
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
++#endif
+ 
+ 
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
+--- gnutls-2.12.20/lib/gl/stdio.in.h
++++ gnutls-2.12.20/lib/gl/stdio.in.h
+@@ -714,8 +714,10 @@
+ /* It is very rare that the developer ever has full control of stdin,
+    so any use of gets warrants an unconditional warning.  Assume it is
+    always declared, since it is required by C89.  */
++#ifdef HAVE_RAW_DECL_GETS
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
++#endif
+ 
+ 
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
Signature · 1 line
1.7.11.3
#1 lore raw

PATCH 1/1 gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

Hi Alexander,

2012/11/9 Alexander Khryukin <[email protected]>:

Quoted 13 lines
Signed-off-by Alexander Khryukin <[email protected]>
---
 package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
package/gnutls/gnutls-2.12.20-glibc2.16.patch new file +0 -0
new file mode 100644
index 0000000..6b7f545

package/gnutls/gnutls-2.12.20-glibc2.16.patch line 2

Quoted 2 lines
package/gnutls/gnutls-2.12.20-glibc2.16.patch new file +2 -0
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h

When adding a patch to a package, we usually add a header to the patch containing a description and the SoB line.

Regards,

Signature · 1 line
Sam
author
#2 lore raw

PATCH 1/1 gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

2012/11/9 Samuel Martin <[email protected]>

Quoted 23 lines

Hi Alexander,

2012/11/9 Alexander Khryukin <[email protected]>:

Quoted 4 lines
Signed-off-by Alexander Khryukin <[email protected]>
---
 package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26

++++++++++++++++++++++++++

Review

Quoted 4 lines
 1 file changed, 26 insertions(+)
 create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch
(quoted diff) +0 -0

b/package/gnutls/gnutls-2.12.20-glibc2.16.patch

package/gnutls/gnutls-2.12.20-glibc2.16.patch line 2

Quoted 7 lines

new file mode 100644
index 0000000..6b7f545

package/gnutls/gnutls-2.12.20-glibc2.16.patch new file +2 -0
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h

When adding a patch to a package, we usually add a header to the patch containing a description and the SoB line.

Quoted 5 lines

Regards,

--
Sam

Looks as my mistake.
In a short time i'll send good patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121109/9678e105/attachment-0001.html>

#3 lore raw

PATCH 1/1 gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

In reply to Samuel Martin
Quoted 18 lines · Samuel Martin

Hi Alexander,

2012/11/9 Alexander Khryukin<[email protected]>:

Quoted 7 lines
Quoted 7 lines
Signed-off-by Alexander Khryukin<[email protected]>

---

   package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++
   1 file changed, 26 insertions(+)

create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch

Quoted 8 lines
Quoted 8 lines

diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch new file mode 100644
index 0000000..6b7f545
--- /dev/null
+++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h

Quoted 2 lines

When adding a patch to a package, we usually add a header to the patch containing a description and the SoB line.

And the commit message itself should also be something more explanatory, e.g.:

gnutls: fix build with glibc2.16, which doesn't declare gets()

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 gnutls-2.12.20-glibc-2.16.patch glibc-2.16 and gnutls2 fix i forgot my signoff

Quoted 22 lines · Arnout Vandecappelle
Quoted 10 lines · Samuel Martin

Hi Alexander,

2012/11/9 Alexander Khryukin<[email protected]>:

Quoted 7 lines
Quoted 7 lines
Signed-off-by Alexander Khryukin<[email protected]>

---
package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch

Quoted 10 lines
Quoted 8 lines

package/gnutls/gnutls-2.12.20-glibc2.16.patch line 2

Quoted 8 lines
package/gnutls/gnutls-2.12.20-glibc2.16.patch new file +2 -0
new file mode 100644
index 0000000..6b7f545
@@ -0,0 +1,26 @@
+--- gnutls-2.12.20/gl/stdio.in.h
++++ gnutls-2.12.20/gl/stdio.in.h

When adding a patch to a package, we usually add a header to the patch containing a description and the SoB line.

Quoted 3 lines

And the commit message itself should also be something more explanatory, e.g.:

gnutls: fix build with glibc2.16, which doesn't declare gets()

BTW, I verified that this indeed fixes the build for glibc2.16, so with a
corrected commit message and a SoB in the patch, this gets my

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F