Skip to contentSkip to conversation

diffutils stdio: don't assume gets any more

PATCH New Alexander Khryukin 2 participants 2 messages Nov 9, 2012 – Nov 10, 2012

lore
Share & tools
lore

Alexander Khryukin

author
#0 lore raw

PATCH 1/1 diffutils stdio: don't assume gets any more

Signed-off-by Alexander Khryukin <[email protected]>
---
 package/diffutils/diffutils-3.2-no-gets.patch | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/diffutils/diffutils-3.2-no-gets.patch
package/diffutils/diffutils-3.2-no-gets.patch new file +21 -0
new file mode 100644
index 0000000..56ca22d
@@ -0,0 +1,21 @@
+hack until gzip pulls a newer gnulib version
+
+From 66712c23388e93e5c518ebc8515140fa0c807348 Mon Sep 17 00:00:00 2001
+From: Eric Blake <[email protected]>
+Date: Thu, 29 Mar 2012 13:30:41 -0600
+Subject: [PATCH] stdio: don't assume gets any more
+
+Gnulib intentionally does not have a gets module, and now that C11
+and glibc have dropped it, we should be more proactive about warning
+any user on a platform that still has a declaration of this dangerous
+interface.
+
+--- a/lib/stdio.in.h
++++ b/lib/stdio.in.h
+@@ -125,7 +125,6 @@
+ /* It is very rare that the developer ever has full control of stdin,
+    so any use of gets warrants an unconditional warning.  Assume it is
+    always declared, since it is required by C89.  */
+-_GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+ #endif
+
Signature · 1 line
1.7.11.3
#1 lore raw

PATCH 1/1 diffutils stdio: don't assume gets any more

Change the commit message into:

diffutils: fix build with glibc2.16, which doesn't declare gets()

Quoted 13 lines · Alexander Khryukin
Signed-off-by Alexander Khryukin<[email protected]>
---
  package/diffutils/diffutils-3.2-no-gets.patch | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)

create mode 100644 package/diffutils/diffutils-3.2-no-gets.patch

package/diffutils/diffutils-3.2-no-gets.patch new file +0 -0
new file mode 100644
index 0000000..56ca22d

package/diffutils/diffutils-3.2-no-gets.patch line 2

Quoted 2 lines
package/diffutils/diffutils-3.2-no-gets.patch new file +2 -0
@@ -0,0 +1,21 @@
+hack until gzip pulls a newer gnulib version
+

You should still add your SoB here, to indicate that you were in the
forwarding path.

Even so,

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

[snip]

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F