Skip to contentSkip to conversation

Add neard and neardal packages

PATCH Superseded spdawson at gmail.com 3 participants 6 messages Nov 9, 2012 – Nov 10, 2012

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

spdawson at gmail.com

author
#0 lore raw

cover Add neard and neardal packages

From: Simon Dawson <[email protected]>

This patch set adds the neard and neardal packages for linux-nfc support.

Simon Dawson (2):
neard: new package
neardal: new package

 package/Config.in          |    2 ++
 package/neard/Config.in    |   15 +++++++++++++++
 package/neard/neard.mk     |   16 ++++++++++++++++
 package/neardal/Config.in  |   11 +++++++++++
 package/neardal/neardal.mk |   16 ++++++++++++++++
 5 files changed, 60 insertions(+)
 create mode 100644 package/neard/Config.in
 create mode 100644 package/neard/neard.mk
 create mode 100644 package/neardal/Config.in
 create mode 100644 package/neardal/neardal.mk
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/2 neard: new package

From: Simon Dawson <[email protected]>

Signed-off-by Simon Dawson <[email protected]>
---
 package/Config.in       |    1 +
 package/neard/Config.in |   15 +++++++++++++++
 package/neard/neard.mk  |   16 ++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/neard/Config.in
 create mode 100644 package/neard/neard.mk
package/Config.in +1 -0
index 2ab6b6e..ffc08ab 100644
@@ -236,6 +236,7 @@ source "package/mdadm/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
+source "package/neard/Config.in"
 source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
package/neard/Config.in new file +15 -0
new file mode 100644
index 0000000..f973fdd
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_NEARD
+	bool "neard"
+	depends on BR2_LINUX_KERNEL
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNL
+	help
+	  Near Field Communication (NFC) manager
+
+	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
+
+	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
+
+comment "neard requires a Linux kernel"
+	depends on !BR2_LINUX_KERNEL
package/neard/neard.mk new file +16 -0
new file mode 100644
index 0000000..3d73932
@@ -0,0 +1,16 @@
+#############################################################
+#
+# neard
+#
+#############################################################
+NEARD_VERSION = 0.7
+NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
+NEARD_INSTALL_STAGING = YES
+NEARD_LICENSE = GPLv2
+NEARD_LICENSE_FILES = COPYING
+
+NEARD_DEPENDENCIES = linux dbus libglib2 libnl
+NEARD_AUTORECONF = YES
+NEARD_CONF_OPT = --disable-traces
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 1/2 neard: new package

package/neard/Config.in line 3

Quoted 9 lines · spdawson at gmail.com
package/neard/Config.in new file +3 -0
new file mode 100644
index 0000000..f973fdd
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_NEARD
+	bool "neard"
+	depends on BR2_LINUX_KERNEL

Why this dependency?

package/neard/Config.in line 8

Quoted 5 lines
package/neard/Config.in new file +5 -0
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNL
+	help
+	  Near Field Communication (NFC) manager

A slightly longer description would be useful here.

package/neard/Config.in line 12

Quoted 4 lines
package/neard/Config.in new file +4 -0
+
+	  http://git.kernel.org/?p=network/nfc/neard.git;a=summary
+
+	  https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...

Those "..." at the end look strange.

Quoted 9 lines
package/neard/neard.mk new file +3 -0
new file mode 100644
index 0000000..3d73932
@@ -0,0 +1,16 @@
+#############################################################
+#
+# neard

package/neard/neard.mk line 13

Quoted 10 lines
package/neard/neard.mk new file +10 -0
+#
+#############################################################
+NEARD_VERSION = 0.7
+NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
+NEARD_INSTALL_STAGING = YES
+NEARD_LICENSE = GPLv2
+NEARD_LICENSE_FILES = COPYING
+
+NEARD_DEPENDENCIES = linux dbus libglib2 libnl
+NEARD_AUTORECONF = YES

The package does not have any patches, and is downloaded from a tarball. Why is an autoreconf needed?

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#3 lore raw

PATCH 1/2 neard: new package

Hi Thomas; thanks for the feedback.

Quoted 4 lines · Thomas Petazzoni
Quoted 2 lines

+ depends on BR2_LINUX_KERNEL

Why this dependency?

You're right; this is superfluous.

Quoted 4 lines

package/neard/Config.in line 8

Quoted 2 lines
package/neard/Config.in new file +2 -0
+     help
+       Near Field Communication (NFC) manager

A slightly longer description would be useful here.

Okay.

Quoted 3 lines
Quoted 1 line

+ https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...

Those "..." at the end look strange.

Yes, they do look strange; but this is correct --- the dots are a required part of the URL.

Quoted 4 lines
Quoted 1 line

+NEARD_AUTORECONF = YES

The package does not have any patches, and is downloaded from a tarball. Why is an autoreconf needed?

The autoreconf is not needed; thanks for pointing this out.

I'll rework the patch.

Simon.

author
#4 lore raw

PATCH 2/2 neardal: new package

In reply to spdawson at gmail.com

From: Simon Dawson <[email protected]>

Signed-off-by Simon Dawson <[email protected]>
---
 package/Config.in          |    1 +
 package/neardal/Config.in  |   11 +++++++++++
 package/neardal/neardal.mk |   16 ++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/neardal/Config.in
 create mode 100644 package/neardal/neardal.mk
package/Config.in +1 -0
index ffc08ab..965830d 100644
@@ -418,6 +418,7 @@ source "package/libusb/Config.in"
 source "package/libusb-compat/Config.in"
 source "package/libv4l/Config.in"
 source "package/mtdev/Config.in"
+source "package/neardal/Config.in"
 source "package/pcsc-lite/Config.in"
 endmenu
package/neardal/Config.in new file +11 -0
new file mode 100644
index 0000000..258a223
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_NEARDAL
+	bool "neardal"
+	depends on BR2_PACKAGE_NEARD
+	select BR2_PACKAGE_DBUS_GLIB
+	help
+	  Provides a simple C API to exchange data with the neard NFC manager daemon.
+
+	  https://github.com/connectivity/neardal
+
+comment "neardal requires neard"
+	depends on !BR2_PACKAGE_NEARD
package/neardal/neardal.mk new file +16 -0
new file mode 100644
index 0000000..3479afd
@@ -0,0 +1,16 @@
+#############################################################
+#
+# neardal
+#
+#############################################################
+NEARDAL_VERSION = 0.7
+NEARDAL_SITE = http://github.com/connectivity/neardal/tarball/$(NEARDAL_VERSION)
+NEARDAL_SOURCE = connectivity-neardal-$(NEARDAL_VERSION).tar.gz
+NEARDAL_INSTALL_STAGING = YES
+NEARDAL_LICENSE = GPLv2
+NEARDAL_LICENSE_FILES = COPYING
+
+NEARDAL_DEPENDENCIES = neard dbus-glib
+NEARDAL_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.10.4
#5 lore raw

PATCH 2/2 neardal: new package

Quoted 1 line · spdawson at gmail.com
Signed-off-by Simon Dawson<[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

(built-test on a minimal powerpc config)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F