Skip to contentSkip to conversation

MAINTAINERS: adjust to livepatch .klp.arch removal

PATCH In review Lukas Bulwahn 3 participants 6 messages May 9, 2020 – May 15, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: adjust to livepatch .klp.arch removal

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

warning: no file matches F: arch/x86/kernel/livepatch.c

So, drop that obsolete file entry in MAINTAINERS.

---
Jiri, please take this minor non-urgent patch for livepatching/for-next. Peter, please ack.

applies cleanly on next-20200508

 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index 92657a132417..642f55c4b556 100644
@@ -9909,7 +9909,6 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
 F:	arch/x86/include/asm/livepatch.h
-F:	arch/x86/kernel/livepatch.c
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/
 F:	samples/livepatch/
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Lukas Bulwahn

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

warning: no file matches F: arch/x86/kernel/livepatch.c

So, drop that obsolete file entry in MAINTAINERS.

Patch looks good to me, you probably want to add following architecture specific livepatching header files to the list:

arch/s390/include/asm/livepatch.h
arch/powerpc/include/asm/livepatch.h

Quoted 24 lines

---
Jiri, please take this minor non-urgent patch for livepatching/for-next. Peter, please ack.

applies cleanly on next-20200508

 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index 92657a132417..642f55c4b556 100644
@@ -9909,7 +9909,6 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
 F:	arch/x86/include/asm/livepatch.h
-F:	arch/x86/kernel/livepatch.c
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/
 F:	samples/livepatch/
Signature · 1 line
Kamalesh
#2 lore raw
Quoted 8 lines · Kamalesh Babulal
Quoted 8 lines

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

warning: no file matches F: arch/x86/kernel/livepatch.c

Quoted 7 lines
Quoted 1 line

So, drop that obsolete file entry in MAINTAINERS.

Patch looks good to me, you probably want to add following architecture specific livepatching header files to the list:

arch/s390/include/asm/livepatch.h
arch/powerpc/include/asm/livepatch.h

Good point, thanks for spotting it Kamalesh. I've queued the patch below on top.

From: Jiri Kosina <[email protected]>
Subject: [PATCH] livepatch: add arch-specific headers to MAINTAINERS

Add arch-specific livepatch.h for s390 and powerpc to MAINTAINERS
F: patterns.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 7e0827670425..8e14444eb98d 100644
@@ -9854,6 +9854,8 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
+F:	arch/powerpc/include/asm/livepatch.h
+F:	arch/s390/include/asm/livepatch.h
 F:	arch/x86/include/asm/livepatch.h
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/
Signature · 2 lines
Jiri Kosina
SUSE Labs
#3 lore raw
Quoted 12 lines · Jiri Kosina
Quoted 10 lines · Kamalesh Babulal
Quoted 9 lines

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

warning: no file matches F: arch/x86/kernel/livepatch.c

So, drop that obsolete file entry in MAINTAINERS.

Quoted 10 lines
Quoted 5 lines

Patch looks good to me, you probably want to add following architecture specific livepatching header files to the list:

arch/s390/include/asm/livepatch.h
arch/powerpc/include/asm/livepatch.h

Good point, thanks for spotting it Kamalesh. I've queued the patch below on top.

Thanks, Jiri. I realized later, that the lib/livepatch directory also needs to be included in the list of files maintained under livepatch. Earlier, this week I had sent a patch to the mailing list that includes both arch headers and lib/livepatch to the list of files, the link to the patch is:

https://lore.kernel.org/live-patching/[email protected]/

Signature · 1 line
Kamalesh
#4 lore raw
Quoted 7 lines · Kamalesh Babulal

Thanks, Jiri. I realized later, that the lib/livepatch directory also needs to be included in the list of files maintained under livepatch. Earlier, this week I had sent a patch to the mailing list that includes both arch headers and lib/livepatch to the list of files, the link to the patch is:

https://lore.kernel.org/live-patching/[email protected]/

Ah, I wasn't CCed, so it fell in between cracks, sorry. Could you please resend the lib/livepatch part separately? I'll apply it on top.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#5 lore raw
In reply to Lukas Bulwahn
Quoted 11 lines · Lukas Bulwahn

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

warning: no file matches F: arch/x86/kernel/livepatch.c

So, drop that obsolete file entry in MAINTAINERS.

I've added

	Fixes: 1d05334d2899 ("livepatch: Remove .klp.arch")

and applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs