Skip to contentSkip to conversation

ARM: S3C64XX: Remove duplicated camera clock

PATCH New dron0gus at gmail.com 4 participants 4 messages Nov 10, 2012 – Nov 12, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

dron0gus at gmail.com

author
#0 lore raw

PATCH 1/2 ARM: S3C64XX: Remove duplicated camera clock

From: Andrey Gusakov <[email protected]>

Camera clock defined two times. One in init_clocks_off array with "cam" name, second in clksrcs array with "camera" name. Leave second definition because clock have divider.

Signed-off-by Andrey Gusakov <[email protected]>
---
 arch/arm/mach-s3c64xx/clock.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
arch/arm/mach-s3c64xx/clock.c +0 -4
index cacbe45..b2d08fa 100644
@@ -319,10 +319,6 @@ static struct clk init_clocks_off[] = {
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_MFC,
 	}, {
-		.name		= "cam",
-		.enable		= s3c64xx_sclk_ctrl,
-		.ctrlbit	= S3C_CLKCON_SCLK_CAM,
-	}, {
 		.name		= "sclk_jpeg",
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_JPEG,
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/2 ARM: S3C64XX: Remove duplicated camera clock

Hi Andrey,

Quoted 16 lines · On Saturday 10 of November 2012 18:07:56 dron0gus at gmail.com wrote:

From: Andrey Gusakov <[email protected]>

Camera clock defined two times. One in init_clocks_off array with "cam" name, second in clksrcs array with "camera" name. Leave second definition because clock have divider.

Signed-off-by Andrey Gusakov <[email protected]>
---
 arch/arm/mach-s3c64xx/clock.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s3c64xx/clock.c index cacbe45..b2d08fa 100644

arch/arm/mach-s3c64xx/clock.c static struct clk init_clocks_off[] = { · line 324

Quoted 10 lines
arch/arm/mach-s3c64xx/clock.c +0 -4
@@ -319,10 +319,6 @@ static struct clk init_clocks_off[] = {
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_MFC,
 	}, {
-		.name		= "cam",
-		.enable		= s3c64xx_sclk_ctrl,
-		.ctrlbit	= S3C_CLKCON_SCLK_CAM,
-	}, {
 		.name		= "sclk_jpeg",
 		.enable		= s3c64xx_sclk_ctrl,
 		.ctrlbit	= S3C_CLKCON_SCLK_JPEG,
Reviewed-by Tomasz Figa <[email protected]>

Best regards,
Tomasz Figa

#2 lore raw

PATCH 1/2 ARM: S3C64XX: Remove duplicated camera clock

In reply to dron0gus at gmail.com
Quoted 7 lines · On 11/10/2012 03:07 PM, dron0gus at gmail.com wrote:

From: Andrey Gusakov<[email protected]>

Camera clock defined two times. One in init_clocks_off array with "cam" name, second in clksrcs array with "camera" name. Leave second definition because clock have divider.

Signed-off-by Andrey Gusakov<[email protected]>
Reviewed-by Sylwester Nawrocki <[email protected]>
Applied
#3 lore raw

PATCH 1/2 ARM: S3C64XX: Remove duplicated camera clock

Quoted 11 lines · Sylwester Nawrocki
Quoted 7 lines · On 11/10/2012 03:07 PM, dron0gus at gmail.com wrote:

From: Andrey Gusakov<[email protected]>

Camera clock defined two times. One in init_clocks_off array with "cam" name, second in clksrcs array with "camera" name. Leave second definition because clock have divider.

Signed-off-by Andrey Gusakov<[email protected]>
Reviewed-by Sylwester Nawrocki <[email protected]>

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.