Skip to contentSkip to conversation

kernel: padata : use __this_cpu_read per-cpu helper

PATCH Applied Shan Wei 3 participants 3 messages Nov 13, 2012

Subsystems (2)
Crypto API Padata parallel execution mechanism
lore
Share & tools
lore

Shan Wei

author
#0 lore raw

PATCH v4 5/9 kernel: padata : use __this_cpu_read per-cpu helper

From: Shan Wei <[email protected]>

For bottom halves off, __this_cpu_read is better.

Signed-off-by Shan Wei <[email protected]>
Reviewed-by Christoph Lameter <[email protected]>

---
no changes vs v4.

---
 kernel/padata.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
kernel/padata.c +2 -3
index 89fe3d1..072f4ee 100644
@@ -171,7 +171,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
 {
 	int cpu, num_cpus;
 	unsigned int next_nr, next_index;
-	struct padata_parallel_queue *queue, *next_queue;
+	struct padata_parallel_queue *next_queue;
 	struct padata_priv *padata;
 	struct padata_list *reorder;
 

@@ -204,8 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
 		goto out;
 	}
 
-	queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
-	if (queue->cpu_index == next_queue->cpu_index) {
+	if (__this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
 		padata = ERR_PTR(-ENODATA);
 		goto out;
 	}
Signature · 1 line
1.7.1
#2 lore raw
Quoted 11 lines · Steffen Klassert
Quoted 6 lines · Shan Wei

From: Shan Wei <[email protected]>

For bottom halves off, __this_cpu_read is better.

Signed-off-by Shan Wei <[email protected]>
Reviewed-by Christoph Lameter <[email protected]>
Acked-by Steffen Klassert <[email protected]>

Herbert, are you going to take this one?

Thanks Steffen, I'll apply his patch.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt