Skip to contentSkip to conversation

net: batman-adv: use per_cpu_add helper

PATCH Applied Shan Wei 2 participants 3 messages Nov 13, 2012

Subsystems (3)
Networking Network drivers Batman advanced
lore
Share & tools
lore

Shan Wei

author
#0 lore raw

PATCH v4 9/9 net: batman-adv: use per_cpu_add helper

From: Shan Wei <[email protected]>

this_cpu_add is an atomic operation.
and be more faster than per_cpu_ptr operation.

Signed-off-by Shan Wei <[email protected]>
Reviewed-by Christoph Lameter <[email protected]>

---
v4: no changes vs v3.

---
 net/batman-adv/main.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
net/batman-adv/main.h +1 -3
index 897ba6a..3aef5b2 100644
@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
 static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
 				      size_t count)
 {
-	int cpu = get_cpu();
-	per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
-	put_cpu();
+	this_cpu_add(bat_priv->bat_counters[idx], count);
 }
 
 #define batadv_inc_counter(b, i) batadv_add_counter(b, i, 1)
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 5 lines · On Tuesday, November 13, 2012 09:53:26 Shan Wei wrote:

From: Shan Wei <[email protected]>

this_cpu_add is an atomic operation.
and be more faster than per_cpu_ptr operation.

Quoted 7 lines
Signed-off-by Shan Wei <[email protected]>
Reviewed-by Christoph Lameter <[email protected]>

---
v4: no changes vs v3.

---
 net/batman-adv/main.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Applied in our tree (revision f8b19e1). We will pass along this patch through our standard workflow. No need to resend this patch in the future.

Thanks,
Marek

author
#2 lore raw

Marek Lindner said, at 2012/11/13 17:55:

Quoted 5 lines
Quoted 2 lines
 net/batman-adv/main.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Applied in our tree (revision f8b19e1). We will pass along this patch through our standard workflow. No need to resend this patch in the future.

OK thanks~

Quoted 4 lines

Thanks,
Marek