Skip to contentSkip to conversation

omap4: Add comments on some "#endif"s for readability.

PATCH In review Robert P. J. Day 3 participants 3 messages Nov 13, 2012 – Dec 10, 2012 Arm (32-bit)

lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

PATCH 1/1 omap4: Add comments on some "#endif"s for readability.

No functional changes, simply for readability.

Signed-off-by Robert P. J. Day <[email protected]>

---

arch/arm/cpu/armv7/omap4/clocks.c +1 -1
index 5bd0a88..12c5803 100644
@@ -44,7 +44,7 @@
  */
 #define printf(fmt, args...)
 #define puts(s)
-#endif
+#endif /* !CONFIG_SPL_BUILD */
 
 struct omap4_prcm_regs *const prcm = (struct omap4_prcm_regs *)0x4A004100;
arch/arm/cpu/armv7/omap4/hwinit.c +2 -2
index 2c34e48..f4123aa 100644
@@ -116,7 +116,7 @@ void do_io_settings(void)
 	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
 		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
 }
-#endif
+#endif /* CONFIG_SPL_BUILD */
 
 /* dummy fuction for omap4 */
 void config_data_eye_leveling_samples(u32 emif_base)

@@ -182,4 +182,4 @@ void v7_outer_cache_disable(void)
 {
 	set_pl310_ctrl_reg(0);
 }
-#endif
+#endif /* !CONFIG_SYS_L2CACHE_OFF */
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw

PATCH 1/1 omap4: Add comments on some "#endif"s for readability.

Quoted 36 lines · Robert P. J. Day

No functional changes, simply for readability.

Signed-off-by Robert P. J. Day <[email protected]>

---

arch/arm/cpu/armv7/omap4/clocks.c +1 -1
index 5bd0a88..12c5803 100644
@@ -44,7 +44,7 @@
   */
  #define printf(fmt, args...)
  #define puts(s)
-#endif
+#endif /* !CONFIG_SPL_BUILD */
 
  struct omap4_prcm_regs *const prcm = (struct omap4_prcm_regs *)0x4A004100;
arch/arm/cpu/armv7/omap4/hwinit.c +1 -1
index 2c34e48..f4123aa 100644
@@ -116,7 +116,7 @@ void do_io_settings(void)
  	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
  		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
  }
-#endif
+#endif /* CONFIG_SPL_BUILD */
 
  /* dummy fuction for omap4 */
  void config_data_eye_leveling_samples(u32 emif_base)

arch/arm/cpu/armv7/omap4/hwinit.c void v7_outer_cache_disable(void) · line 185

Quoted 5 lines
arch/arm/cpu/armv7/omap4/hwinit.c +1 -1
@@ -182,4 +182,4 @@ void v7_outer_cache_disable(void)
  {
  	set_pl310_ctrl_reg(0);
  }
-#endif
+#endif /* !CONFIG_SYS_L2CACHE_OFF */

Thanks..

Regards,
Sricharan

#2 lore raw
In reply to Robert P. J. Day
Quoted 3 lines · Robert P. J. Day

No functional changes, simply for readability.

Signed-off-by Robert P. J. Day <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121210/dc5a4174/attachment.pgp>