Skip to contentSkip to conversation

Silence "make clean"

U-Boot New Wolfgang Denk 5 participants 10 messages Nov 13, 2012 – Nov 15, 2012 Kbuild

lore
Share & tools
lore
#0 lore raw

Dear Marek,

your commit 30ff8918 ("kerneldoc: Implant DocBook from Linux kernel") causes "make clean" (and all other targets that use this implicitly) to spit out these messages:

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a theory that it's impossible to prove anything, but  I  can't
prove it.
#1 lore raw

Dear Wolfgang Denk,

Quoted 6 lines

Dear Marek,

your commit 30ff8918 ("kerneldoc: Implant DocBook from Linux kernel") causes "make clean" (and all other targets that use this implicitly) to spit out these messages:

Quoted 6 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Is this not fixed in latest sources? I believe Tom fixed it.

Quoted 3 lines

Best regards,

Wolfgang Denk

Best regards,
Marek Vasut

#2 lore raw

Dear Marek Vasut,

Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 7 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Is this not fixed in latest sources? I believe Tom fixed it.

It is not fixed in current top of tree in master, i. e. v2013.01-rc1-78-g59852d0

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The good Christian should beware of mathematicians and all those who
make empty prophecies. The danger already exists that  mathematicians
have  made a covenant with the devil to darken the spirit and confine
man in the bonds of Hell."                          - Saint Augustine
#3 lore raw
Quoted 7 lines · Wolfgang Denk

Dear Marek Vasut,

Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Is this not fixed in latest sources? I believe Tom fixed it.

It is not fixed in current top of tree in master, i. e. v2013.01-rc1-78-g59852d0

Tom did only 'fix' a special case for MAKEALL:
ed296d206a1840c0a0b6c1322379c950f9996905

Best regards

Andreas Bie?mann

#4 lore raw

Dear Andreas Bie?mann,

Quoted 11 lines · Wolfgang Denk
Quoted 10 lines

Dear Marek Vasut,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 6 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Is this not fixed in latest sources? I believe Tom fixed it.

It is not fixed in current top of tree in master, i. e. v2013.01-rc1-78-g59852d0

Tom did only 'fix' a special case for MAKEALL:
ed296d206a1840c0a0b6c1322379c950f9996905

How do you even replicate this? I don't see it on my box :-(

Best regards,
Marek Vasut

#5 lore raw

Dear Marek Vasut,

Quoted 15 lines · Marek Vasut

Dear Andreas Bie?mann,

Quoted 13 lines · Wolfgang Denk
Quoted 12 lines

Dear Marek Vasut,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Is this not fixed in latest sources? I believe Tom fixed it.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

It is not fixed in current top of tree in master, i. e. v2013.01-rc1-78-g59852d0

Tom did only 'fix' a special case for MAKEALL:
ed296d206a1840c0a0b6c1322379c950f9996905

How do you even replicate this?

just call 'make clean' in your u-boot source ;)

Best regards

Andreas Bie?mann

#6 lore raw

Dear Andreas Bie?mann,

Quoted 21 lines

Dear Marek Vasut,

Quoted 18 lines · Marek Vasut

Dear Andreas Bie?mann,

Quoted 16 lines · Wolfgang Denk
Quoted 14 lines

Dear Marek Vasut,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines

make[1]: Entering directory .../doc/DocBook' make[1]: Leaving directory .../doc/DocBook'

We didn't have this before, and we shouldn't have this.

Can you please fix this regression? Thanks.

Is this not fixed in latest sources? I believe Tom fixed it.

It is not fixed in current top of tree in master, i. e. v2013.01-rc1-78-g59852d0

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Tom did only 'fix' a special case for MAKEALL:
ed296d206a1840c0a0b6c1322379c950f9996905

How do you even replicate this?

just call 'make clean' in your u-boot source ;)

Let me just crawl under my rock now ... I'll pop up again once I'm over my shame.

... sum ... sum ... sum ... plop ...

Best regards,
Marek Vasut

#7 lore raw

PATCH 1/1 Makefile: silence 'make clean'

In reply to Andreas Bießmann
Cc Marek Vasut <[email protected]>
Cc Wolfgang Denk <[email protected]>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 9dc89f9..5fa2fba 100644
@@ -811,7 +811,7 @@ clean:
 	@rm -f $(obj)include/generated/asm-offsets.h
 	@rm -f $(obj)$(CPUDIR)/$(SOC)/asm-offsets.s
 	@rm -f $(TIMESTAMP_FILE) $(VERSION_FILE)
-	@$(MAKE) -C doc/DocBook/ cleandocs
+	@$(MAKE) -s -C doc/DocBook/ cleandocs
 	@find $(OBJTREE) -type f \
 		\( -name 'core' -o -name '*.bak' -o -name '*~' -o -name '*.su' \
 		-o -name '*.o'	-o -name '*.a' -o -name '*.exe'	\) -print \
Signature · 1 line
1.7.10.4
#9 lore raw

PATCH 1/1 Makefile: silence 'make clean'

In reply to Andreas Bießmann
Quoted 3 lines · Andreas Bie?mann
Cc Marek Vasut <[email protected]>
Cc Wolfgang Denk <[email protected]>

Thanks

Dirk

Quoted 17 lines
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 9dc89f9..5fa2fba 100644
@@ -811,7 +811,7 @@ clean:
 	@rm -f $(obj)include/generated/asm-offsets.h
 	@rm -f $(obj)$(CPUDIR)/$(SOC)/asm-offsets.s
 	@rm -f $(TIMESTAMP_FILE) $(VERSION_FILE)
-	@$(MAKE) -C doc/DocBook/ cleandocs
+	@$(MAKE) -s -C doc/DocBook/ cleandocs
 	@find $(OBJTREE) -type f \
 		\( -name 'core' -o -name '*.bak' -o -name '*~' -o -name '*.su' \
 		-o -name '*.o'	-o -name '*.a' -o -name '*.exe'	\) -print \