ARM: gic: Fix sparse warning

PATCH New Tushar Behera 2 participants 4 messages Nov 19, 2012 – Nov 20, 2012 Arm (32-bit)

lore

Share & tools

lore

Tushar Behera

author

2012-11-19 10:58 UTC #0 lore raw

PATCH 1/1 ARM: gic: Fix sparse warning

gic_irq_domain_ops is only used in this file, so should be marked as static.

Fixes following compilation warning.

arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was not declared. Should it be static?

Signed-off-by Tushar Behera <[email protected]>

---
 arch/arm/common/gic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/common/gic.c +1 -1

index aa52699..4896dec 100644
@@ -635,7 +635,7 @@ static int gic_irq_domain_xlate(struct irq_domain *d,
 	return 0;
 }
 
-const struct irq_domain_ops gic_irq_domain_ops = {
+static const struct irq_domain_ops gic_irq_domain_ops = {
 	.map = gic_irq_domain_map,
 	.xlate = gic_irq_domain_xlate,
 };

Signature · 1 line

1.7.4.1

Sergei Shtylyov

2012-11-19 12:42 UTC #1 lore raw

PATCH 1/1 ARM: gic: Fix sparse warning

Hello.

Quoted 4 lines · Tushar Behera

gic_irq_domain_ops is only used in this file, so should be marked as static.
Fixes following compilation warning.

This is sparse's warning, not compiler's, if I don't mistake.

Quoted 4 lines

arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was not declared. Should it be static?
Signed-off-by Tushar Behera <[email protected]>

WBR, Sergei

Tushar Behera

author

2012-11-20 03:26 UTC #2 lore raw

PATCH 1/1 ARM: gic: Fix sparse warning

Quoted 11 lines · Sergei Shtylyov

Hello.
Quoted 4 lines · Tushar Behera
gic_irq_domain_ops is only used in this file, so should be marked as static.
Fixes following compilation warning.
This is sparse's warning, not compiler's, if I don't mistake.

My mistake. It is indeed sparse warning.

Quoted 8 lines

Quoted 4 lines
arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was not declared. Should it be static?
Signed-off-by Tushar Behera <[email protected]>
WBR, Sergei

Signature · 1 line

Tushar Behera

Sergei Shtylyov

2012-11-20 13:00 UTC #3 lore raw

PATCH 1/1 ARM: gic: Fix sparse warning

Quoted 8 lines · Tushar Behera

Quoted 6 lines
Quoted 4 lines
gic_irq_domain_ops is only used in this file, so should be marked as static.
Fixes following compilation warning.
This is sparse's warning, not compiler's, if I don't mistake.
My mistake. It is indeed sparse warning.

And I didn't read your subject, where it's called correctly. :-)

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
arch/arm/common/gic.c:638:29: warning: symbol 'gic_irq_domain_ops' was not declared. Should it be static?
Signed-off-by Tushar Behera <[email protected]>

WBR, Sergei