Skip to contentSkip to conversation

be_main.c:273 always evaluates to 'false'

DISCUSSION Hannes Reinecke 1 participant 1 message Nov 20, 2012 SCSI

lore
Share & tools
lore
#0 lore raw

Hi Jayamohan,

drivers/scsi/be2iscsi/be_main.c:273 has this statement:

if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)

	continue;

which is pointless at best, and actually harmful at worst as it probably should compare with the scmd as passed to

beiscsi_eh_device_reset(struct scsi_cmnd *sc)

You might want to fix it up.

Cheers,

Hannes

Signature · 8 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html