ext4: remove unaligned AIO warning printk
PATCH 1/1 ext4: remove unaligned AIO warning printk
Although I put this in, I now think it was a bad decision. For most users, there is very little to be done in this case. They get the message, once per day, with no real context or proposed action. TBH, it generates support calls when it probably does not need to; the message sounds more dire than the situation really is.
Just nuke it. Normal investigation via blktrace or whatnot can reveal poor IO patterns if bad performance is encountered.
---
fs/ext4/file.c +0 -1
@@ -107,14 +107,6 @@ ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,/* Unaligned direct AIO must be serialized; see comment above */ if (unaligned_aio) { -static unsigned long unaligned_warn_time;
Theodore Ts'o
maintainerQuoted 8 lines · Eric Sandeen
Although I put this in, I now think it was a bad decision. For most users, there is very little to be done in this case. They get the message, once per day, with no real context or proposed action. TBH, it generates support calls when it probably does not need to; the message sounds more dire than the situation really is.
Just nuke it. Normal investigation via blktrace or whatnot can reveal poor IO patterns if bad performance is encountered.
I wonder if this might be a good thing to enable or disable via sysfs tuning knob, just to make it a little easier for a random application developer to test for this?
And do you have a list of the bad applications so we can nag them to fix them?
- Ted
Quoted 7 lines · Theodore Ts'o
Quoted 6 lines · Eric Sandeen
Although I put this in, I now think it was a bad decision. For most users, there is very little to be done in this case. They get the message, once per day, with no real context or proposed action. TBH, it generates support calls when it probably does not need to; the message sounds more dire than the situation really is.
Quoted 6 lines
Quoted 2 lines
Just nuke it. Normal investigation via blktrace or whatnot can reveal poor IO patterns if bad performance is encountered.
I wonder if this might be a good thing to enable or disable via sysfs tuning knob, just to make it a little easier for a random application developer to test for this?
*shrug* would be more knobs & more complexity; I bet 99% of people reporting it would never have known the knob was there, and doubtful they'd have turned it on. If developers cared, they'd probably have done the proper thing in the first place. I guess I'm skeptical of the usefulness.
Quoted 2 lines
And do you have a list of the bad applications so we can nag them to fix them?
Whenever we get it reported, it's some proprietary thing. So no, not really, I'm afraid.
But google live search thinks it's virtualbox, kvm, and java ;)
"Unaligned AIO/DIO on inode" turns up plenty.
Can you do some sort of google-grep-awk to find every app that's been reported on lists? ;)
-Eric
Quoted 2 lines
- Ted
Quoted 10 lines · Eric Sandeen
Although I put this in, I now think it was a bad decision. For most users, there is very little to be done in this case. They get the message, once per day, with no real context or proposed action. TBH, it generates support calls when it probably does not need to; the message sounds more dire than the situation really is.
Just nuke it. Normal investigation via blktrace or whatnot can reveal poor IO patterns if bad performance is encountered.
Signed-off-by Eric Sandeen <[email protected]>
Thanks, applied.
- Ted