event notifier: Fix setup for win32
PATCH 1/1 event notifier: Fix setup for win32
The event notifier state is only reset by test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events.
---
Grr, the last place I looked at after hours of debugging...
event_notifier-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
event_notifier-win32.c +1 -1
@@ -16,7 +16,7 @@int event_notifier_init (EventNotifier *e,int active) { - e->event =CreateEvent (NULL , FALSE, FALSE,NULL ); + e->event =CreateEvent (NULL , TRUE, FALSE,NULL );assert (e->event);return 0 ; }
Signature · 1 line
1.7.3.4
Quoted 10 lines · Jan Kiszka
The event notifier state is only reset by
test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events.Signed-off-by Jan Kiszka <[email protected]>---
Grr, the last place I looked at after hours of debugging...
event_notifier-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
This should be in QEMU 1.3.
Il 23/11/2012 08:08, Stefan Hajnoczi ha scritto:
Quoted 7 lines · Jan Kiszka
Quoted 6 lines
The event notifier state is only reset by
test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events.Signed-off-by Jan Kiszka <[email protected]>---
Quoted 8 lines
Quoted 4 lines
Grr, the last place I looked at after hours of debugging...
event_notifier-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)This should be in QEMU 1.3.
Reviewed-by Stefan Hajnoczi <[email protected]>
Anthony, the patch is at
http://article.gmane.org/gmane.comp.emulators.qemu/181608/raw
Please apply it for -rc2.
Paolo
Anthony Liguori
AppliedQuoted 4 lines · Jan Kiszka
The event notifier state is only reset by
test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events.Signed-off-by Jan Kiszka <[email protected]>
Applied. Thanks.
Regards,
Anthony Liguori
Quoted 22 lines
---
Grr, the last place I looked at after hours of debugging...
event_notifier-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)event_notifier-win32.c +1
-1@@ -16,7 +16,7 @@int event_notifier_init (EventNotifier *e,int active) { - e->event =CreateEvent (NULL , FALSE, FALSE,NULL ); + e->event =CreateEvent (NULL , TRUE, FALSE,NULL );assert (e->event);return 0 ; }Signature · 1 line
1.7.3.4