Skip to contentSkip to conversation

gstreamer: Added option to disable plugin

PATCH Superseded Tim Sheridan 2 participants 2 messages Nov 22, 2012 – Nov 24, 2012

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tim Sheridan

author
#0 lore raw

PATCH v2 1/1 gstreamer: Added option to disable plugin

The plugin registry can take a while to be generated when GStreamer is initialized. Turning it off speeds up GStreamer application launch times. Default behaviour is unchanged.

Signed-off-by Tim Sheridan <[email protected]>
---
 package/multimedia/gstreamer/Config.in    |    9 +++++++++
 package/multimedia/gstreamer/gstreamer.mk |    3 ++- 
 2 files changed, 11 insertions(+), 1 deletions(-)
package/multimedia/gstreamer/Config.in +9 -0
index 4d279b8..e946b18 100644
@@ -16,5 +16,14 @@ config BR2_PACKAGE_GSTREAMER_GST_DEBUG
          in gstreamer. This has limited CPU overhead, but does
          increase the rootfs size somewhat.
 
+config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
+       bool "enable plugin registry"
+       default y
+       depends on BR2_PACKAGE_GSTREAMER
+       help
+         Enable support for the GStreamer plugin registry.
+         This may increase the launch-time for a GStreamer
+         application.
+
 comment "gstreamer requires a toolchain with WCHAR support"
        depends on !BR2_USE_WCHAR
package/multimedia/gstreamer/gstreamer.mk +3 -1
index a9841b1..b87f029 100644
@@ -21,7 +21,8 @@ GSTREAMER_CONF_OPT = \
                --disable-tests \
                --disable-failing-tests \
                --disable-loadsave \
-               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug)
+               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug) \
+               $(if 
+ $(BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY),,--disable-registry)
 
 GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf

--
1.7.1

#1 lore raw

PATCH v2 1/1 gstreamer: Added option to disable plugin

Hi Tim,

The whitespace in your patch is messed up by your e-mail client. Please use
git send-email to avoid this.

Quoted 1 line · Tim Sheridan

The plugin registry can take a while to be generated when GStreamer is initialized. Turning it off speeds up GStreamer application launch times. Default behaviour is unchanged.

Please wrap the commit message at +- 72 characters

Quoted 13 lines
Signed-off-by Tim Sheridan<[email protected]>
---
  package/multimedia/gstreamer/Config.in    |    9 +++++++++
  package/multimedia/gstreamer/gstreamer.mk |    3 ++-
  2 files changed, 11 insertions(+), 1 deletions(-)
package/multimedia/gstreamer/Config.in +0 -0
index 4d279b8..e946b18 100644
@@ -16,5 +16,14 @@ config BR2_PACKAGE_GSTREAMER_GST_DEBUG
           in gstreamer. This has limited CPU overhead, but does

package/multimedia/gstreamer/Config.in config BR2_PACKAGE_GSTREAMER_GST_DEBUG · line 26

Quoted 10 lines
package/multimedia/gstreamer/Config.in +8 -0
           increase the rootfs size somewhat.
 
+config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
+       bool "enable plugin registry"
+       default y
+       depends on BR2_PACKAGE_GSTREAMER
+       help
+         Enable support for the GStreamer plugin registry.
+         This may increase the launch-time for a GStreamer
+         application.

The Config.in things should be indented with 1 tab, help text with
1 tab and 2 spaces. Wrapping should be at 80 characters, with the tab counting as 8 characters.

Quoted 8 lines
package/multimedia/gstreamer/Config.in +1 -0
+
  comment "gstreamer requires a toolchain with WCHAR support"
         depends on !BR2_USE_WCHAR
package/multimedia/gstreamer/gstreamer.mk +0 -0
index a9841b1..b87f029 100644

package/multimedia/gstreamer/gstreamer.mk GSTREAMER_CONF_OPT = \ · line 26

Quoted 7 lines
package/multimedia/gstreamer/gstreamer.mk +3 -1
@@ -21,7 +21,8 @@ GSTREAMER_CONF_OPT = \
                 --disable-tests \
                 --disable-failing-tests \
                 --disable-loadsave \
-               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug)
+               $(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug) \
+               $(if
+ $(BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY),,--disable-registry)

No need to split this line, even if it goes over 80 characters. It's less readable
when split.

All my comments are just whitespace-related, so:

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 5 lines
package/multimedia/gstreamer/gstreamer.mk +0 -1
  GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf
 
--

1.7.1

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F