Skip to contentSkip to conversation

HID: hid-input: battery quirk for Apple keyboard

PATCH In review Ortwin Glück 4 participants 4 messages Nov 25, 2012 – Nov 26, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: hid-input: battery quirk for Apple keyboard

Support battery capacity on another Apple wireless keyboard.

NB: most likely all other APPLE_ALU_WIRELESS_*
keyboards should be added as well.

---

drivers/hid/hid-input.c +3 -0
index 5301006..b2ae097 100644
@@ -299,6 +299,9 @@ static enum power_supply_property hidinput_battery_props[] = {
 
 static const struct hid_device_id hid_battery_quirks[] = {
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO),
+         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
                               USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
          HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
#2 lore raw
Quoted 3 lines · devendra.aaru

i think you should simply do a cc: [email protected] just right above your signedoff-by, which is the way that stable patches gets into i think.

It's OK to cc stable@ when submitting a patch, but that line must be included in the commit message to ensure it actually gets considered for stable updates.

Ben.

Signature · 2 lines
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.
#3 lore raw
In reply to Ortwin Glück
Quoted 2 lines · Ortwin Glück

Support battery capacity on another Apple wireless keyboard.

Your patch has been whitespace damaged. I have fixed it by hand and applied, but please fix your process for any future patch submissions. Thanks.

Quoted 2 lines

NB: most likely all other APPLE_ALU_WIRELESS_* keyboards should be added as well.

I think it's likely true, but I prefer to have it actually tested before doing such changes blindly.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs