Skip to contentSkip to conversation

xfs: Remove the description about nodelaylog mount option from, the xfs document.

PATCH In review Satoru Takeuchi 2 participants 4 messages Nov 26, 2012 – Nov 27, 2012 Documentation

lore
Share & tools
lore

Satoru Takeuchi

author
#0 lore raw

PATCH 1/1 xfs: Remove the description about nodelaylog mount option from, the xfs document.

From: Satoru Takeuchi <[email protected]>

nodelaylog mount option is removed by commit 93b8a585. But there still be the description about it in the xfs document. This patch removes it.

Signed-off-by Satoru Takeuchi <[email protected]>
---
 Documentation/filesystems/xfs.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/xfs.txt +1 -1
index 3fc0c31..860b845 100644
@@ -43,7 +43,7 @@ When mounting an XFS filesystem, the following options are accepted.
        Issue command to let the block device reclaim space freed by the
        filesystem.  This is useful for SSD devices, thinly provisioned
        LUNs and virtual machine images, but may have a performance
-       impact.  This option is incompatible with the nodelaylog option.
+       impact.
 
   dmapi
        Enable the DMAPI (Data Management API) event callouts.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Satoru Takeuchi

From: Satoru Takeuchi <[email protected]>

nodelaylog mount option is removed by commit 93b8a585. But there still be the description about it in the xfs document. This patch removes it.

Signed-off-by Satoru Takeuchi <[email protected]>
---
 Documentation/filesystems/xfs.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/xfs.txt +0 -0
index 3fc0c31..860b845 100644

Documentation/filesystems/xfs.txt When mounting an XFS filesystem, the following options are accepted. · line 46

Quoted 5 lines
Documentation/filesystems/xfs.txt +1 -1
@@ -43,7 +43,7 @@ When mounting an XFS filesystem, the following options are accepted.
        Issue command to let the block device reclaim space freed by the
        filesystem.  This is useful for SSD devices, thinly provisioned
        LUNs and virtual machine images, but may have a performance
-       impact.  This option is incompatible with the nodelaylog option.
+       impact.

Looks good.

Reviewed-by Ben Myers <[email protected]>

Thanks Satoru!

-Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw

Hey Satoru,

Quoted 24 lines · Ben Myers
Quoted 15 lines · Satoru Takeuchi

From: Satoru Takeuchi <[email protected]>

nodelaylog mount option is removed by commit 93b8a585. But there still be the description about it in the xfs document. This patch removes it.

Signed-off-by Satoru Takeuchi <[email protected]>
---
 Documentation/filesystems/xfs.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/xfs.txt +0 -0
index 3fc0c31..860b845 100644

Documentation/filesystems/xfs.txt When mounting an XFS filesystem, the following options are accepted. · line 46

Quoted 5 lines
Documentation/filesystems/xfs.txt +1 -1
@@ -43,7 +43,7 @@ When mounting an XFS filesystem, the following options are accepted.
        Issue command to let the block device reclaim space freed by the
        filesystem.  This is useful for SSD devices, thinly provisioned
        LUNs and virtual machine images, but may have a performance
-       impact.  This option is incompatible with the nodelaylog option.
+       impact.

Looks good.

Quoted 1 line
Reviewed-by Ben Myers <[email protected]>

This has been committed to git://oss.sgi.com/xfs/xfs.git, master and for-next branches. It seems like your mailer replaced tabs with spaces so I cleaned that up. Just a heads-up... you may want to look into that.

Thanks!
Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

author
#3 lore raw
Quoted 27 lines · Ben Myers

Hey Satoru,

Quoted 24 lines · Ben Myers
Quoted 15 lines · Satoru Takeuchi

From: Satoru Takeuchi <[email protected]>

nodelaylog mount option is removed by commit 93b8a585. But there still be the description about it in the xfs document. This patch removes it.

Signed-off-by Satoru Takeuchi <[email protected]>
---
 Documentation/filesystems/xfs.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/filesystems/xfs.txt +0 -0
index 3fc0c31..860b845 100644

Documentation/filesystems/xfs.txt When mounting an XFS filesystem, the following options are accepted. · line 46

Quoted 5 lines
Documentation/filesystems/xfs.txt +1 -1
@@ -43,7 +43,7 @@ When mounting an XFS filesystem, the following options are accepted.
        Issue command to let the block device reclaim space freed by the
        filesystem.  This is useful for SSD devices, thinly provisioned
        LUNs and virtual machine images, but may have a performance
-       impact.  This option is incompatible with the nodelaylog option.
+       impact.

Looks good.

Quoted 5 lines
Quoted 1 line
Reviewed-by Ben Myers <[email protected]>

This has been committed to git://oss.sgi.com/xfs/xfs.git, master and for-next branches. It seems like your mailer replaced tabs with spaces so I cleaned that up. Just a heads-up... you may want to look into that.

I apologize to you. I copy-and-past this patch from my terminal and it converts tab to spaces. I'll be careful from now on.

Thanks,
Satoru

Quoted 9 lines

Thanks!
Ben

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs