Skip to contentSkip to conversation

mac80211: add debugfs file for last ack signal

RFC In review Saravana 2 participants 3 messages Nov 28, 2012 mac80211

lore
Share & tools
lore

Saravana

author
#0 lore raw

RFC 1/1 mac80211: add debugfs file for last ack signal

Add a debugfs file showing the signal strength
of the ack frame that is received for the
currently sent tx packet

Signed-off-by Saravana <[email protected]>
---
 net/mac80211/debugfs_sta.c |    2 ++
 net/mac80211/sta_info.h    |    2 ++
 net/mac80211/status.c      |    2 ++
 3 files changed, 6 insertions(+), 0 deletions(-)
net/mac80211/debugfs_sta.c +2 -0
index 89281d2..1566941 100644
@@ -53,6 +53,7 @@ static const struct file_operations sta_ ##name## _ops = {		\
 STA_FILE(aid, sta.aid, D);
 STA_FILE(dev, sdata->name, S);
 STA_FILE(last_signal, last_signal, D);
+STA_FILE(last_ack_signal, last_ack_signal, D);
 
 static ssize_t sta_flags_read(struct file *file, char __user *userbuf,
 			      size_t count, loff_t *ppos)

@@ -369,6 +370,7 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
 	DEBUGFS_ADD(dev);
 	DEBUGFS_ADD(last_signal);
 	DEBUGFS_ADD(ht_capa);
+	DEBUGFS_ADD(last_ack_signal);
 
 	DEBUGFS_ADD_COUNTER(rx_packets, rx_packets);
 	DEBUGFS_ADD_COUNTER(tx_packets, tx_packets);
net/mac80211/sta_info.h +2 -0
index 6835cea..dce7693 100644
@@ -250,6 +250,7 @@ struct sta_ampdu_mlme {
  * @rx_dropped: number of dropped MPDUs from this STA
  * @last_signal: signal of last received frame from this STA
  * @avg_signal: moving average of signal of received frames from this STA
+ * @last_ack_signal: signal of last received Ack frame from this STA
  * @last_seq_ctrl: last received seq/frag number from this STA (per RX queue)
  * @tx_filtered_count: number of frames the hardware filtered for this STA
  * @tx_retry_failed: number of frames that failed retry

@@ -329,6 +330,7 @@ struct sta_info {
 	unsigned long rx_dropped;
 	int last_signal;
 	struct ewma avg_signal;
+	int last_ack_signal;
 	/* Plus 1 for non-QoS frames */
 	__le16 last_seq_ctrl[IEEE80211_NUM_TIDS + 1];
net/mac80211/status.c +2 -0
index 2d931ad..64dda41 100644
@@ -539,6 +539,8 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 				sta->lost_packets = 0;
 			}
 		}
+		if (acked)
+			sta->last_ack_signal = info->status.ack_signal;
 	}
 
 	rcu_read_unlock();
maintainer
#1 lore raw
Quoted 56 lines · Saravana

Add a debugfs file showing the signal strength
of the ack frame that is received for the
currently sent tx packet

Signed-off-by Saravana <[email protected]>
---
 net/mac80211/debugfs_sta.c |    2 ++
 net/mac80211/sta_info.h    |    2 ++
 net/mac80211/status.c      |    2 ++
 3 files changed, 6 insertions(+), 0 deletions(-)
net/mac80211/debugfs_sta.c +2 -0
index 89281d2..1566941 100644
@@ -53,6 +53,7 @@ static const struct file_operations sta_ ##name## _ops = {		\
 STA_FILE(aid, sta.aid, D);
 STA_FILE(dev, sdata->name, S);
 STA_FILE(last_signal, last_signal, D);
+STA_FILE(last_ack_signal, last_ack_signal, D);
 
 static ssize_t sta_flags_read(struct file *file, char __user *userbuf,
 			      size_t count, loff_t *ppos)

@@ -369,6 +370,7 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
 	DEBUGFS_ADD(dev);
 	DEBUGFS_ADD(last_signal);
 	DEBUGFS_ADD(ht_capa);
+	DEBUGFS_ADD(last_ack_signal);
 
 	DEBUGFS_ADD_COUNTER(rx_packets, rx_packets);
 	DEBUGFS_ADD_COUNTER(tx_packets, tx_packets);
net/mac80211/sta_info.h +2 -0
index 6835cea..dce7693 100644
@@ -250,6 +250,7 @@ struct sta_ampdu_mlme {
  * @rx_dropped: number of dropped MPDUs from this STA
  * @last_signal: signal of last received frame from this STA
  * @avg_signal: moving average of signal of received frames from this STA
+ * @last_ack_signal: signal of last received Ack frame from this STA
  * @last_seq_ctrl: last received seq/frag number from this STA (per RX queue)
  * @tx_filtered_count: number of frames the hardware filtered for this STA
  * @tx_retry_failed: number of frames that failed retry

@@ -329,6 +330,7 @@ struct sta_info {
 	unsigned long rx_dropped;
 	int last_signal;
 	struct ewma avg_signal;
+	int last_ack_signal;
 	/* Plus 1 for non-QoS frames */
 	__le16 last_seq_ctrl[IEEE80211_NUM_TIDS + 1];
net/mac80211/status.c +0 -0
index 2d931ad..64dda41 100644

net/mac80211/status.c void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb) · line 543

Quoted 5 lines
net/mac80211/status.c +2 -0
@@ -539,6 +539,8 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 				sta->lost_packets = 0;
 			}
 		}
+		if (acked)
+			sta->last_ack_signal = info->status.ack_signal;

I'd prefer a blank line before the if

This patch was sent in a way that I could apply it. :-)

johannes

author
#2 lore raw
Quoted 7 lines · Johannes Berg

net/mac80211/status.c void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb) · line 543

Quoted 2 lines
net/mac80211/status.c +2 -0
+		if (acked)
+			sta->last_ack_signal = info->status.ack_signal;

I'd prefer a blank line before the if

This patch was sent in a way that I could apply it. :-)

will re-submit the patch with the blank line inserted before the if.

Quoted 3 lines

johannes