Skip to contentSkip to conversation

libsigc: Don't copy devel documentation onto target

PATCH New Charles Manning 3 participants 3 messages Nov 30, 2012 – Dec 1, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 libsigc: Don't copy devel documentation onto target

The libsigc++ developer documentation was being copied onto the target. Add a clean-up to fix that.

There is probably a better way to do this but I still have training wheels.

---
 package/libsigc/libsigc.mk |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
package/libsigc/libsigc.mk +6 -0
index 92d1d8b..10f5803 100644
@@ -8,4 +8,10 @@ LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
 LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
 LIBSIGC_INSTALL_STAGING = YES
 
+define LIBSIGC_INSTALL_TARGET_FIXUP
+	rm -rf $(TARGET_DIR)/usr/share/devhelp/books/libsigc++*
+endef
+
+LIBSIGC_POST_INSTALL_TARGET_HOOKS += LIBSIGC_INSTALL_TARGET_FIXUP
+
 $(eval $(autotools-package))
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 libsigc: Don't copy devel documentation onto target

Quoted 4 lines · Charles Manning

The libsigc++ developer documentation was being copied onto the target. Add a clean-up to fix that.

There is probably a better way to do this but I still have training wheels.

A command like that should typically go below ---, otherwise it will
appear in the git log for all eternity...

Quoted 2 lines
Quoted 9 lines
---
  package/libsigc/libsigc.mk |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)
package/libsigc/libsigc.mk +0 -0
index 92d1d8b..10f5803 100644

package/libsigc/libsigc.mk LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2 · line 12

Quoted 5 lines
package/libsigc/libsigc.mk +2 -0
@@ -8,4 +8,10 @@ LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
  LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
  LIBSIGC_INSTALL_STAGING = YES
 
+define LIBSIGC_INSTALL_TARGET_FIXUP
+	rm -rf $(TARGET_DIR)/usr/share/devhelp/books/libsigc++*

Perhaps we should globally remove devhelp together with man and doc?
OTOH this is currently the only package that installs anything in devhelp.

BTW, if someone wanted to remark that this shouldn't be done if
BR2_HAVE_DOCUMENTATION is y: we don't have a devhelp reader, so installing the devhelp texts is always pointless.

Regards,
Arnout

Quoted 5 lines
package/libsigc/libsigc.mk +4 -0
+endef
+
+LIBSIGC_POST_INSTALL_TARGET_HOOKS += LIBSIGC_INSTALL_TARGET_FIXUP
+
  $(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 2/2 libsigc: Don't copy devel documentation onto target

In reply to Charles Manning
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Charles" == Charles Manning <[email protected]> writes:

Charles> The libsigc++ developer documentation was being copied onto the target. Charles> Add a clean-up to fix that.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard