Skip to contentSkip to conversation

drm/vmwgfx: always use ttm_bo_is_reserved

PATCH In review Maarten Lankhorst 2 participants 2 messages Nov 30, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/vmwgfx: always use ttm_bo_is_reserved

This was missed during the initial conversion, most likely due to the refactoring here.

---
Woops, forgot to stg refresh before sending, fixed. :-)

drivers/gpu/drm/vmwgfx/vmwgfx_resource.c +2 -2
index 93dffe3..ddc8db8 100644
@@ -939,13 +939,13 @@ void vmw_resource_unreserve(struct vmw_resource *res,
 	if (new_backup && new_backup != res->backup) {
 
 		if (res->backup) {
-			BUG_ON(atomic_read(&res->backup->base.reserved) == 0);
+			BUG_ON(!ttm_bo_is_reserved(&res->backup->base));
 			list_del_init(&res->mob_head);
 			vmw_dmabuf_unreference(&res->backup);
 		}
 
 		res->backup = vmw_dmabuf_reference(new_backup);
-		BUG_ON(atomic_read(&new_backup->base.reserved) == 0);
+		BUG_ON(!ttm_bo_is_reserved(&new_backup->base));
 		list_add_tail(&res->mob_head, &new_backup->res_list);
 	}
 	if (new_backup)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Maarten Lankhorst

This was missed during the initial conversion, most likely due to the refactoring here.

---
Woops, forgot to stg refresh before sending, fixed. :-)

drivers/gpu/drm/vmwgfx/vmwgfx_resource.c +2 -2
index 93dffe3..ddc8db8 100644
@@ -939,13 +939,13 @@ void vmw_resource_unreserve(struct vmw_resource *res,
  	if (new_backup && new_backup != res->backup) {
 
  		if (res->backup) {
-			BUG_ON(atomic_read(&res->backup->base.reserved) == 0);
+			BUG_ON(!ttm_bo_is_reserved(&res->backup->base));
  			list_del_init(&res->mob_head);
  			vmw_dmabuf_unreference(&res->backup);
  		}
 
  		res->backup = vmw_dmabuf_reference(new_backup);
-		BUG_ON(atomic_read(&new_backup->base.reserved) == 0);
+		BUG_ON(!ttm_bo_is_reserved(&new_backup->base));
  		list_add_tail(&res->mob_head, &new_backup->res_list);
  	}
  	if (new_backup)