Skip to contentSkip to conversation

mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

PATCH In review Chaitanya 2 participants 3 messages Dec 7, 2012 1 message not in the archive mac80211

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201212070645.qB76jSjN013395@chaitanya-desktop

Chaitanya

author
#1 lore raw

PATCH 1/1 mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log.

---
net/mac80211/agg-tx.c | 2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
net/mac80211/agg-tx.c +1 -1
index 4152ed1..eb9df22 100644
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
 	trace_api_start_tx_ba_session(pubsta, tid);
 
-	if (WARN_ON(!local->ops->ampdu_action))
+	if (WARN_ON_ONCE(!local->ops->ampdu_action))
 		return -EINVAL;
 
 	if ((tid >= IEEE80211_NUM_TIDS) ||
maintainer
#2 lore raw
Quoted 5 lines · Chaitanya

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any

Yay, this worked. Applied with a changed commit log.

johannes

author
#3 lore raw

Great to hear that johannes.
Finally after exhausting all options used the sendmail and it worked :-)

Quoted 9 lines · Johannes Berg
Quoted 4 lines · Chaitanya

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any

Yay, this worked. Applied with a changed commit log.

johannes