Skip to contentSkip to conversation

pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support

PATCH New Arnout Vandecappelle (Essensium/Mind) 3 participants 3 messages Dec 6, 2012 – Dec 7, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support

From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>

The legal-info target (and possibly others as well) depends on <pkg>-extract to make sure the license file is available. However, when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target doesn't exist.

To solve this, we add <pkg>-extract which depends on <pkg>-rsync. While we're at it, we do the same for <pkg>-patch. That avoids the same problem in the future if something starts depending on <pkg>-patch.

---
v2: As ThomasP suggested, don't remove <pkg>-rsync.

---
 package/pkg-generic.mk |    3 +++
 1 file changed, 3 insertions(+)
package/pkg-generic.mk +3 -0
index 6fcd359..13c1d83 100644
@@ -390,6 +390,9 @@ $(1)-configure:		$(1)-depends \
 
 $(1)-depends:		$(1)-rsync $$($(2)_DEPENDENCIES)
 
+$(1)-patch:		$(1)-rsync
+$(1)-extract:		$(1)-rsync
+
 $(1)-rsync:		$$($(2)_TARGET_RSYNC)
 
 $(1)-source:		$$($(2)_TARGET_RSYNC_SOURCE)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Hi,

Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]> Arnout> The legal-info target (and possibly others as well) depends on Arnout> <pkg>-extract to make sure the license file is available. However, Arnout> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target Arnout> doesn't exist.

Arnout> To solve this, we add <pkg>-extract which depends on <pkg>-rsync. Arnout> While we're at it, we do the same for <pkg>-patch. That avoids the Arnout> same problem in the future if something starts depending on Arnout> <pkg>-patch.

Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> Acked-by: Thomas Petazzoni <[email protected]> Arnout> Acked-by: Luca Ceresoli <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support

Am 07.12.2012 02:14, schrieb Peter Korsgaard:

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Hi,

Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]> Arnout> The legal-info target (and possibly others as well) depends on Arnout> <pkg>-extract to make sure the license file is available. However, Arnout> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target Arnout> doesn't exist.

Arnout> To solve this, we add <pkg>-extract which depends on <pkg>-rsync. Arnout> While we're at it, we do the same for <pkg>-patch. That avoids the Arnout> same problem in the future if something starts depending on Arnout> <pkg>-patch.

Quoted 6 lines

Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> Acked-by: Thomas Petazzoni <[email protected]> Arnout> Acked-by: Luca Ceresoli <[email protected]>

Committed, thanks.

Thanks, now legal info works together with OVERRIDE.

Stephan

Signature · 4 lines
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de