Allow 0ms deadline latency

PATCH In review xtu4 2 participants 3 messages Dec 9, 2012 Block layer

lore

Share & tools

lore

xtu4

author

2012-12-09 16:06 UTC #0 lore raw

PATCH 1/1 Allow 0ms deadline latency

Subject: [PATCH] Allow 0ms deadline latency, increase the read speed

Signed-off-by xiaobing tu <[email protected]>

---
block/deadline-iosched.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

block/deadline-iosched.c +1 -1

index c644137..e502d6b 100644
@@ -230,7 +230,7 @@ static inline int deadline_check_fifo(struct deadline_data *dd, int ddir)
       /*
        * rq is expired!
        */
-       if (time_after(jiffies, rq_fifo_time(rq)))
+       if (time_after_eq(jiffies, rq_fifo_time(rq)))
               return 1;
 
        return 0;

Signature · 1 line

1.7.6

xtu4

author

2012-12-09 16:08 UTC #1 lore raw

re-send it

Quoted 21 lines · On 12/10/2012 12:01 AM, xtu4 wrote:

Subject: [PATCH] Allow 0ms deadline latency, increase the read speed

Signed-off-by xiaobing tu <[email protected]>

---
block/deadline-iosched.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

block/deadline-iosched.c +1 -1

index c644137..e502d6b 100644
@@ -230,7 +230,7 @@ static inline int deadline_check_fifo(struct 
 deadline_data *dd, int ddir)
       /*
        * rq is expired!
        */
-       if (time_after(jiffies, rq_fifo_time(rq)))
+       if (time_after_eq(jiffies, rq_fifo_time(rq)))
               return 1;

        return 0;

Jens Axboe

maintainer

2012-12-09 18:18 UTC #2 lore raw

Quoted 21 lines · On 2012-12-09 17:02, xtu4 wrote:

Quoted 20 lines · On 12/10/2012 12:01 AM, xtu4 wrote:
Subject: [PATCH] Allow 0ms deadline latency, increase the read speed
Signed-off-by xiaobing tu <[email protected]>
---
block/deadline-iosched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
block/deadline-iosched.c +1 -1
index c644137..e502d6b 100644
@@ -230,7 +230,7 @@ static inline int deadline_check_fifo(struct 
 deadline_data *dd, int ddir)
       /*
        * rq is expired!
        */
-       if (time_after(jiffies, rq_fifo_time(rq)))
+       if (time_after_eq(jiffies, rq_fifo_time(rq)))
               return 1;
 

Quoted 1 line

        return 0;

Looks fine, it allows FIFO behaviour for deadline as well. I have applied it.

Signature · 1 line

Jens Axboe