Skip to contentSkip to conversation

rbd: remove linger unconditionally

PATCH New Alex Elder 1 participant 1 message Dec 10, 2012 Ceph common code (libceph)

lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH 1/1 rbd: remove linger unconditionally

In __unregister_linger_request(), the request is being removed from the osd client's req_linger list only when the request has a non-null osd pointer. It should be done whether or not the request currently has an osd.

This is most likely a non-issue because I believe the request will always have an osd when this function is called.

---
 net/ceph/osd_client.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ceph/osd_client.c +0 -0
index c018e52..218a97f 100644
@@ -833,8 +833,8 @@ static void __unregister_linger_request(struct

ceph_osd_client *osdc,
struct ceph_osd_request *req)
{
dout("__unregister_linger_request %p\n", req);
+ list_del_init(&req->r_linger_item);
if (req->r_osd) {
- list_del_init(&req->r_linger_item);
list_del_init(&req->r_linger_osd);

if (list_empty(&req->r_osd->o_requests) &&

Signature · 1 line
1.7.9.5