arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const

Signed-off-by Cong Ding <[email protected]>

---
arch/x86/tools/gen-insn-attr-x86.awk | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

index ddcf39b..d1d9cfa 100644
@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"
 \
+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)

		for (j = 0; j < max_lprefix; j++)

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

Patch description please?

Quoted 30 lines · Cong Ding

Signed-off-by Cong Ding <[email protected]>

---
arch/x86/tools/gen-insn-attr-x86.awk | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

index ddcf39b..d1d9cfa 100644
@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"
 \
+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)

		for (j = 0; j < max_lprefix; j++)

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

Signature · 1 line

Sent from my mobile phone. Please excuse brevity and lack of formatting.

Quoted 1 line · H. Peter Anvin

Patch description please?

there are 2 consts in the definition of one variable

Quoted 4 lines · Cong Ding

Quoted 1 line · H. Peter Anvin

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

From 1abfab824ed2dc0af6e283ea0b7a6c45541d4fd1 Mon Sep 17 00:00:00 2001

Quoted 8 lines · H. Peter Anvin

Quoted 4 lines · Cong Ding

Quoted 1 line · H. Peter Anvin

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 11 lines · Cong Ding

Quoted 8 lines · H. Peter Anvin

Quoted 4 lines · Cong Ding

Quoted 1 line · H. Peter Anvin

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00 2001

Quoted 13 lines · H. Peter Anvin

Quoted 11 lines · Cong Ding

Quoted 8 lines · H. Peter Anvin

Quoted 4 lines · Cong Ding

Quoted 1 line · H. Peter Anvin

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 6 lines

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Quoted 9 lines

Quoted 8 lines

Quoted 6 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 6 lines

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00 2001
From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and inat_avx_tables

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

arch/x86/tools/gen-insn-attr-x86.awk +3 -3

index ddcf39b..987c7b2 100644
@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]" \
+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX + 1]"\
+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

From 9523e1de9d2771dc66a5b645651fc9f4745eb685 Mon Sep 17 00:00:00 2001

Quoted 9 lines · Cong Ding

Quoted 9 lines

Quoted 8 lines

Quoted 6 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line (subject line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 8 lines

Quoted 6 lines

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +1 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]" \
+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1]" \

Cong, could you update your patch? then I can Ack that.

Quoted 5 lines · Cong Ding

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line

(subject

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 8 lines

Quoted 6 lines

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX +

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX +

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

No, that would really be wrong - changing the type.

Quoted 92 lines · Masami Hiramatsu

Quoted 5 lines · Cong Ding

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line

(subject

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Quoted 8 lines

Quoted 6 lines

Well, except that typically you should explain which variable it is. Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX +

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX +

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

Quoted 1 line · H. Peter Anvin

No, that would really be wrong - changing the type.

What would be wrong? IMHO, this is just a fix to add a fool proof 'const' to array instance itself.
...Or, am I missed anything?

Thank you,

Quoted 7 lines

Quoted 5 lines · Masami Hiramatsu

Quoted 4 lines · Cong Ding

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Quoted 7 lines

Quoted 7 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Please put in an actual patch description. The first line

(subject

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable it

is.

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

Quoted 8 lines

Review

Quoted 8 lines

Quoted 2 lines

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]"

Quoted 68 lines

Quoted 67 lines

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX +

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX +

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

Yes, if you add a * it becomes an array of pointers.

Quoted 106 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

No, that would really be wrong - changing the type.

What would be wrong? IMHO, this is just a fix to add a fool proof 'const' to array instance itself.
...Or, am I missed anything?

Thank you,

Quoted 7 lines

Quoted 5 lines · Masami Hiramatsu

Quoted 4 lines · Cong Ding

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Quoted 7 lines

Quoted 7 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Please put in an actual patch description. The first line

(subject

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable it

is.

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Yes, it is obvious if you look at the patch, but you're making the reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks anything or is just a cosmetic issue.

Quoted 8 lines

Review

Quoted 8 lines

Quoted 2 lines

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]"

Quoted 68 lines

Quoted 67 lines

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX +

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX +

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX +

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

Quoted 1 line · H. Peter Anvin

Yes, if you add a * it becomes an array of pointers.

Right, I would like to make each pointer in the array read-only.

And, of course, the data itself which pointed by the pointer is already protected.
You can see this in (builddir)/arch/x86/lib/inat_table.c
----
/* Table: 2-byte opcode (0x0f) */
const insn_attr_t inat_escape_table_1[INAT_OPCODE_TABLE_SIZE] = { [...]
/* Escape opcode map array */
const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1][INAT_LSTPFX_MAX +

1] = {
       [1][0] = inat_escape_table_1,

----

So I think Cong's v3 is good :)

Thank you,

Quoted 20 lines

Quoted 17 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

No, that would really be wrong - changing the type.

What would be wrong? IMHO, this is just a fix to add a fool proof 'const' to array instance itself.
...Or, am I missed anything?

Thank you,

Quoted 8 lines

Quoted 6 lines · Masami Hiramatsu

Quoted 5 lines · Cong Ding

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line

Quoted 8 lines

Quoted 8 lines

Quoted 6 lines

Quoted 6 lines

(subject

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable it

is.

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Yes, it is obvious if you look at the patch, but you're making

the

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks

anything

Quoted 9 lines

Quoted 9 lines

Quoted 9 lines

Review

Quoted 9 lines

Quoted 3 lines

Quoted 1 line

or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX

+

Quoted 3 lines

Quoted 3 lines

1]"

Quoted 2 lines

Review

Quoted 2 lines

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX

+

Quoted 31 lines

Quoted 31 lines

Quoted 31 lines

Quoted 31 lines

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX

+

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 1 line

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]"

\

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX

+

Quoted 18 lines

Quoted 17 lines

Quoted 17 lines

Quoted 16 lines

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

You're changing the array from an array of insn_attr_t to pointers to insn_attr_t?

Quoted 140 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

Yes, if you add a * it becomes an array of pointers.

Right, I would like to make each pointer in the array read-only.

And, of course, the data itself which pointed by the pointer is already protected.
You can see this in (builddir)/arch/x86/lib/inat_table.c
----
/* Table: 2-byte opcode (0x0f) */
const insn_attr_t inat_escape_table_1[INAT_OPCODE_TABLE_SIZE] = { [...]
/* Escape opcode map array */
const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1][INAT_LSTPFX_MAX +

1] = {
       [1][0] = inat_escape_table_1,

----

So I think Cong's v3 is good :)

Thank you,

Quoted 20 lines

Quoted 17 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

No, that would really be wrong - changing the type.

What would be wrong? IMHO, this is just a fix to add a fool proof 'const' to array instance itself.
...Or, am I missed anything?

Thank you,

Quoted 8 lines

Quoted 6 lines · Masami Hiramatsu

Quoted 5 lines · Cong Ding

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Please put in an actual patch description. The first line

Quoted 8 lines

Quoted 8 lines

Quoted 6 lines

Quoted 6 lines

(subject

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable it

is.

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Yes, it is obvious if you look at the patch, but you're making

the

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks

anything

Quoted 9 lines

Quoted 9 lines

Quoted 9 lines

Review

Quoted 9 lines

Quoted 3 lines

Quoted 1 line

or is just a cosmetic issue.

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX

+

Quoted 3 lines

Quoted 3 lines

1]"

Quoted 2 lines

Review

Quoted 2 lines

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX

+

Quoted 31 lines

Quoted 31 lines

Quoted 31 lines

Quoted 31 lines

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX

+

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 1 line

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]"

\

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX

+

Quoted 18 lines

Quoted 17 lines

Quoted 17 lines

Quoted 16 lines

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 9 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -1

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 5 lines

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)

Quoted 1 line · H. Peter Anvin

You're changing the array from an array of insn_attr_t to pointers to

insn_attr_t?

No, please look at the code carefully,

(quoted diff) +0 -1

-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"

\
                                     ^^

(quoted diff) +1 -0

+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX +

1]" \
                               ^^

Both are pointers of array.

I'd just change the position of const.

const insn_attr_t const * -> const insn_attr_t * const

Thank you,

Quoted 45 lines

Quoted 42 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

Yes, if you add a * it becomes an array of pointers.

Right, I would like to make each pointer in the array read-only.

And, of course, the data itself which pointed by the pointer is already protected.
You can see this in (builddir)/arch/x86/lib/inat_table.c
----
/* Table: 2-byte opcode (0x0f) */
const insn_attr_t inat_escape_table_1[INAT_OPCODE_TABLE_SIZE] = { [...]
/* Escape opcode map array */
const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1][INAT_LSTPFX_MAX +

1] = {
       [1][0] = inat_escape_table_1,

----

So I think Cong's v3 is good :)

Thank you,

Quoted 19 lines

Quoted 16 lines · Masami Hiramatsu

Quoted 1 line · H. Peter Anvin

No, that would really be wrong - changing the type.

What would be wrong? IMHO, this is just a fix to add a fool proof 'const' to array instance itself.
...Or, am I missed anything?

Thank you,

Quoted 7 lines

Quoted 5 lines · Masami Hiramatsu

Quoted 4 lines · Cong Ding

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

Patch description please?

there are 2 consts in the definition of one variable

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Please put in an actual patch description. The first line

(subject

Quoted 5 lines

Quoted 5 lines

Quoted 3 lines

Quoted 1 line

line) is a title; the patch should make sense without it.

sorry for that. so like this is fine?

Well, except that typically you should explain which variable

it

Quoted 8 lines

Quoted 8 lines

Quoted 2 lines

Quoted 2 lines

is.

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Yes, it is obvious if you look at the patch, but you're making

the

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

reader spend a few more moments than necessary.

Also, you should explain what the harm is -- if it breaks

anything

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

or is just a cosmetic issue.

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Review

Quoted 8 lines

Quoted 2 lines

sorry again for lacking of experience... and I missed another same error, so send version 2.

Ah, sorry for my mistake. I would like to make both the value pointed by the pointers and the pointers itself read-only. Thus the right way of the patch should be;

(quoted diff) +0 -1

-	print "const insn_attr_t const

*inat_escape_tables[INAT_ESC_MAX

Quoted 4 lines

Quoted 4 lines

+

Quoted 3 lines

Quoted 3 lines

1]"

Quoted 2 lines

Review

Quoted 2 lines

\

(quoted diff) +1 -0

+	print "const insn_attr_t * const

inat_escape_tables[INAT_ESC_MAX

Quoted 11 lines

Quoted 11 lines

+

Quoted 10 lines

Quoted 10 lines

Quoted 10 lines

Quoted 10 lines

1]" \

Cong, could you update your patch? then I can Ack that.

Thank you,

Quoted 4 lines

- cong
---
From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17

00:00:00

Quoted 21 lines

Quoted 21 lines

Quoted 21 lines

Quoted 21 lines

Quoted 21 lines

Quoted 21 lines

2001

Quoted 3 lines

From: Cong Ding <[email protected]>
Date: Fri, 7 Dec 2012 23:14:32 +0000
Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove

duplicate const

Quoted 7 lines

fix the following sparse warning:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for variable inat_escape_tables, inat_group_tables, and

inat_avx_tables

Review

Quoted 7 lines

Signed-off-by Cong Ding <[email protected]>

---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

(quoted diff) +0 -0

b/arch/x86/tools/gen-insn-attr-x86.awk

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 8 lines

index ddcf39b..987c7b2 100644

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const

*inat_escape_tables[INAT_ESC_MAX

Quoted 3 lines

Quoted 3 lines

+

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

1]" \

arch/x86/tools/gen-insn-attr-x86.awk END { · line 359

Quoted 1 line

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX +

1]"

Quoted 9 lines

Quoted 9 lines

\

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const

*inat_group_tables[INAT_GRP_MAX

Quoted 3 lines

Quoted 3 lines

+

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 368

Quoted 1 line

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX +

1]"\

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 8 lines

arch/x86/tools/gen-insn-attr-x86.awk +0 -1

 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)

@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX

+

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

1]"\

arch/x86/tools/gen-insn-attr-x86.awk END { · line 377

Quoted 1 line

arch/x86/tools/gen-insn-attr-x86.awk +1 -0

+	print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX +

1]"\

Quoted 7 lines

Quoted 6 lines

Quoted 6 lines

Quoted 5 lines

Quoted 5 lines

Quoted 4 lines

Quoted 4 lines

arch/x86/tools/gen-insn-attr-x86.awk +0 -0

 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)