xfs: don't zero structure members after a memset(0)
PATCH 1/1 xfs: don't zero structure members after a memset(0)
Commit 408cc4e97a3ccd172d2d676e4b585badf439271b added memset(0, ...) to allocation args structures, so there is no need to explicitly set any of the fields to 0 after that.
---
Note, compile-tested only.
fs/xfs/xfs_alloc.c +0 -2
@@ -1871,8 +1871,6 @@ xfs_alloc_fix_freelist( targs.mp = mp; targs.agbp = agbp; targs.agno = args->agno; - targs.mod = targs.minleft = targs.wasdel = targs.userdata = - targs.minalignslop =0 ; targs.alignment = targs.minlen = targs.prod = targs.isfl =1 ; targs.type =XFS_ALLOCTYPE_THIS_AG ; targs.pag = pag;
fs/xfs/xfs_bmap.c +0 -4
@@ -3098,8 +3098,6 @@ xfs_bmap_extents_to_btree( args.fsbno = *firstblock; } args.minlen = args.maxlen = args.prod =1 ; - args.total = args.minleft = args.alignment = args.mod = args.isfl = - args.minalignslop =0 ; args.wasdel = wasdel; *logflagsp =0 ;if ((error =xfs_alloc_vextent (&args))) {
@@ -3257,8 +3255,6 @@ xfs_bmap_local_to_extents( args.type =XFS_ALLOCTYPE_NEAR_BNO ; } args.total = total; - args.mod = args.minleft = args.alignment = args.wasdel = - args.isfl = args.minalignslop =0 ; args.minlen = args.maxlen = args.prod =1 ;if ((error =xfs_alloc_vextent (&args))) goto done;
fs/xfs/xfs_ialloc.c +0 -4
@@ -277,8 +277,6 @@ xfs_ialloc_ag_alloc( (args.agbno < be32_to_cpu(agi->agi_length)))) { args.fsbno =XFS_AGB_TO_FSB (args.mp, agno, args.agbno); args.type =XFS_ALLOCTYPE_THIS_BNO ; - args.mod = args.total = args.wasdel = args.isfl = - args.userdata = args.minalignslop =0 ; args.prod =1 ;/*
@@ -331,8 +329,6 @@ xfs_ialloc_ag_alloc(* Allocate a fixed-size extent of inodes. */ args.type =XFS_ALLOCTYPE_NEAR_BNO ; - args.mod = args.total = args.wasdel = args.isfl = - args.userdata = args.minalignslop =0 ; args.prod =1 ;/* * Allow space for the inode btree to split.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 9 lines · Eric Sandeen
Commit
408cc4e97a3ccd172d2d676e4b585badf439271baddedmemset(0, ...)to allocation args structures, so there is no need to explicitly set any of the fields to 0 after that.Signed-off-by Eric Sandeen<[email protected]>---
Note, compile-tested only.
Thank-you for cleaning up the junk I left behind.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs