Skip to contentSkip to conversation

woodburn: Set gpio value in gpio_direction_output()

PATCH New Fabio Estevam 2 participants 3 messages Dec 11, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 woodburn: Set gpio value in gpio_direction_output()

Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value call.

---
 board/woodburn/woodburn.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/woodburn/woodburn.c +1 -2
index 66a0d35..d74f360 100644
@@ -133,8 +133,7 @@ int woodburn_init(void)
 	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
 	gpio_direction_output(4, 1);
 	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
-	gpio_direction_output(9, 0);
-	gpio_set_value(9, 1);
+	gpio_direction_output(9, 1);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 woodburn: Set gpio value in gpio_direction_output()

Quoted 14 lines · Fabio Estevam

Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value call.

---
 board/woodburn/woodburn.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/woodburn/woodburn.c +0 -0
index 66a0d35..d74f360 100644

board/woodburn/woodburn.c int woodburn_init(void) · line 139

Quoted 9 lines
board/woodburn/woodburn.c +1 -2
@@ -133,8 +133,7 @@ int woodburn_init(void)
 	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
 	gpio_direction_output(4, 1);
 	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
-	gpio_direction_output(9, 0);
-	gpio_set_value(9, 1);
+	gpio_direction_output(9, 1);
 
 	return 0;
 }

Thanks !

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 woodburn: Set gpio value in gpio_direction_output()

In reply to Fabio Estevam
Quoted 14 lines · Fabio Estevam

Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value call.

---
 board/woodburn/woodburn.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/woodburn/woodburn.c +0 -0
index 66a0d35..d74f360 100644

board/woodburn/woodburn.c int woodburn_init(void) · line 139

Quoted 9 lines
board/woodburn/woodburn.c +1 -2
@@ -133,8 +133,7 @@ int woodburn_init(void)
 	mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
 	gpio_direction_output(4, 1);
 	mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
-	gpio_direction_output(9, 0);
-	gpio_set_value(9, 1);
+	gpio_direction_output(9, 1);
 
 	return 0;
 }

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================